From: Andreas Schwab <schwab@linux-m68k.org>
To: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] linux: mips: Fix getdents64 fallback on mips64-n32
Date: Mon, 16 Nov 2020 22:40:46 +0100 [thread overview]
Message-ID: <875z659e01.fsf@igel.home> (raw)
In-Reply-To: <20201116211743.2228063-1-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Mon, 16 Nov 2020 18:17:43 -0300")
On Nov 16 2020, Adhemerval Zanella via Libc-alpha wrote:
> diff --git a/sysdeps/unix/sysv/linux/mips/mips64/getdents64.c b/sysdeps/unix/sysv/linux/mips/mips64/getdents64.c
> index d18a5297dc..5b7597c99b 100644
> --- a/sysdeps/unix/sysv/linux/mips/mips64/getdents64.c
> +++ b/sysdeps/unix/sysv/linux/mips/mips64/getdents64.c
> @@ -91,15 +91,18 @@ __getdents64 (int fd, void *buf, size_t nbytes)
> while ((char *) kdp < (char *) skdp + r)
> {
> /* This macro is used to avoid aliasing violation. */
> -#define KDP_MEMBER(src, member) \
> - (__typeof__((struct kernel_dirent){0}.member) *) \
> - memcpy (&((__typeof__((struct kernel_dirent){0}.member)){0}), \
> - ((char *)(src) + offsetof (struct kernel_dirent, member)),\
> - sizeof ((struct kernel_dirent){0}.member))
> +#define KDP_MEMBER(member) \
> + ({ \
> + __typeof ((struct kernel_dirent){0}.member) kdp_tmp; \
> + memcpy (&kdp_tmp, \
> + ((char *)(kdp) + offsetof (struct kernel_dirent, member)), \
> + sizeof (kdp_tmp)); \
> + kdp_tmp; \
> + })
Why can't this just be kdp->member?
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
prev parent reply other threads:[~2020-11-16 21:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 21:17 Adhemerval Zanella
2020-11-16 21:22 ` Florian Weimer
2020-11-17 13:19 ` Adhemerval Zanella
2020-11-17 13:38 ` Andreas Schwab
2020-11-17 17:37 ` Adhemerval Zanella
2020-11-17 17:51 ` Florian Weimer
2020-11-17 18:08 ` Adhemerval Zanella
2021-01-22 12:49 ` Florian Weimer
2021-01-22 14:20 ` Adhemerval Zanella
2021-01-22 16:02 ` Florian Weimer
2020-11-16 21:40 ` Andreas Schwab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875z659e01.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).