Re: V2 [PATCH 2/2] Add C wrappers for prctl/process_vm_readv/process_vm_writev [BZ #25810]

[Florian Weimer <fweimer@redhat.com>]

* H. J. Lu:

> On Wed, Apr 29, 2020 at 8:32 AM Andreas Schwab <schwab@linux-m68k.org> wrote:
>>
>> On Apr 29 2020, H.J. Lu via Libc-alpha wrote:
>>
>> >> > +int
>> >> > +__prctl (int option, unsigned long arg2, unsigned long arg3,
>> >> > +   unsigned long arg4, unsigned long arg5)
>> >>
>> >> unsigned long int everywhere.
>> >
>> > Fixed.
>> >
>> >>
>> >> > +{
>> >> > +  return INLINE_SYSCALL_CALL (prctl, option, arg2, arg3, arg4, arg5);
>> >> > +}
>> >> > +
>> >> > +hidden_def (__prctl)
>> >> > +weak_alias (__prctl, prctl)
>> >> > +hidden_weak (prctl)
>> >>
>> >> Can't you use libc_hidden_proto in include/sys/prctl.h and
>> >> libc_hidden_proto here?
>> >>
>> >
>> > Since include/sys/prctl.h has
>> >
>> > extern int __prctl (int __option, ...);
>> >
>> > it can't be used.
>>
>> You cannot implement a function declared as varargs with a non-varargs
>> definition.
>
> True.  There is a separate bug:
>
> https://sourceware.org/bugzilla/show_bug.cgi?id=25896

I suggest to drop prctl from process_vm_*v fix and commit only the
latter now.

Thanks,
Florian