From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by sourceware.org (Postfix) with ESMTP id 65E4338930CB for ; Wed, 29 Apr 2020 15:43:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 65E4338930CB Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-512-gFDyw874Pum8xDECkMCMZw-1; Wed, 29 Apr 2020 11:43:04 -0400 X-MC-Unique: gFDyw874Pum8xDECkMCMZw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EEFE4107ACCA; Wed, 29 Apr 2020 15:43:02 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-114-9.ams2.redhat.com [10.36.114.9]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1BA4A1002395; Wed, 29 Apr 2020 15:43:01 +0000 (UTC) From: Florian Weimer To: "H.J. Lu" Cc: Andreas Schwab , "H.J. Lu via Libc-alpha" Subject: Re: V2 [PATCH 2/2] Add C wrappers for prctl/process_vm_readv/process_vm_writev [BZ #25810] References: <20200429144727.3769136-1-hjl.tools@gmail.com> <20200429144727.3769136-2-hjl.tools@gmail.com> <87d07qs5n4.fsf@oldenburg2.str.redhat.com> <20200429152017.GA3811691@gmail.com> <87zhau2tpa.fsf@igel.home> Date: Wed, 29 Apr 2020 17:43:00 +0200 In-Reply-To: (H. J. Lu's message of "Wed, 29 Apr 2020 08:36:22 -0700") Message-ID: <875zdiqovv.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_BL, RCVD_IN_MSPIKE_L3, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Apr 2020 15:43:22 -0000 * H. J. Lu: > On Wed, Apr 29, 2020 at 8:32 AM Andreas Schwab wr= ote: >> >> On Apr 29 2020, H.J. Lu via Libc-alpha wrote: >> >> >> > +int >> >> > +__prctl (int option, unsigned long arg2, unsigned long arg3, >> >> > + unsigned long arg4, unsigned long arg5) >> >> >> >> unsigned long int everywhere. >> > >> > Fixed. >> > >> >> >> >> > +{ >> >> > + return INLINE_SYSCALL_CALL (prctl, option, arg2, arg3, arg4, arg= 5); >> >> > +} >> >> > + >> >> > +hidden_def (__prctl) >> >> > +weak_alias (__prctl, prctl) >> >> > +hidden_weak (prctl) >> >> >> >> Can't you use libc_hidden_proto in include/sys/prctl.h and >> >> libc_hidden_proto here? >> >> >> > >> > Since include/sys/prctl.h has >> > >> > extern int __prctl (int __option, ...); >> > >> > it can't be used. >> >> You cannot implement a function declared as varargs with a non-varargs >> definition. > > True. There is a separate bug: > > https://sourceware.org/bugzilla/show_bug.cgi?id=3D25896 I suggest to drop prctl from process_vm_*v fix and commit only the latter now. Thanks, Florian