From: Florian Weimer <fw@deneb.enyo.de>
To: Zack Weinberg <zackw@panix.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] misc: Turn sstk into a compat symbol
Date: Mon, 27 Apr 2020 14:52:35 +0200 [thread overview]
Message-ID: <875zdlxf8s.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <CAKCAbMg80i1-rcC5NDKdRygD5WXhsx05E9pH-Vegp_qs5yM9kQ@mail.gmail.com> (Zack Weinberg's message of "Mon, 27 Apr 2020 08:38:26 -0400")
* Zack Weinberg:
> On Mon, Apr 27, 2020 at 7:01 AM Florian Weimer <fw@deneb.enyo.de> wrote:
>>
>> It is not implemented anywhere. There is an osf_sstk system call on
>> alpha, but it is not used to implement sstk, and the system call
>> is not implemented on Linux, either.
>
> Maybe you should also remove the entry for sstk from
> sysdeps/unix/syscalls.list?
Indeed, and I also forgot to add attribute_compat_text_section.
8<------------------------------------------------------------------8<
Subject: misc: Remove sstk from the autogenerated system call list
This change should not have an effect because the system call was
never defined. Also add the misssing attribute_compat_text_section
attribute to the sstk function (a minor optimization).
Fixes commit 9cc93ba0973ad04ee26c515a1552afb85e73c6ba
("misc: Turn sstk into a compat symbol").
diff --git a/misc/sstk.c b/misc/sstk.c
index 0a2a967917..dda6f7b426 100644
--- a/misc/sstk.c
+++ b/misc/sstk.c
@@ -19,7 +19,7 @@
#include <shlib-compat.h>
#if SHLIB_COMPAT (libc, GLIBC_2_0, GLIBC_2_32)
-void *
+void * attribute_compat_text_section
sstk (int increment)
{
__set_errno (ENOSYS);
diff --git a/sysdeps/unix/syscalls.list b/sysdeps/unix/syscalls.list
index 01c4a0e6b1..e8f8718b04 100644
--- a/sysdeps/unix/syscalls.list
+++ b/sysdeps/unix/syscalls.list
@@ -78,7 +78,6 @@ sigaction - sigaction i:ipp __sigaction sigaction
sigsuspend - sigsuspend Ci:p sigsuspend
socket - socket i:iii __socket socket
socketpair - socketpair i:iiif socketpair
-sstk - sstk b:i sstk
statfs - statfs i:sp __statfs statfs
swapoff - swapoff i:s swapoff
swapon - swapon i:s swapon
next prev parent reply other threads:[~2020-04-27 12:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 10:21 Florian Weimer
2020-04-27 10:38 ` Andreas Schwab
2020-04-27 12:38 ` Zack Weinberg
2020-04-27 12:52 ` Florian Weimer [this message]
2020-04-27 20:31 ` Joseph Myers
2020-04-28 10:11 ` Florian Weimer
2020-04-28 10:35 ` Florian Weimer
2020-04-28 14:57 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zdlxf8s.fsf@mid.deneb.enyo.de \
--to=fw@deneb.enyo.de \
--cc=libc-alpha@sourceware.org \
--cc=zackw@panix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).