From: Florian Weimer <fweimer@redhat.com>
To: Carlos O'Donell <carlos@redhat.com>
Cc: libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Fix build with -march=486 -Os (Bug 25240)
Date: Tue, 03 Dec 2019 21:41:00 -0000 [thread overview]
Message-ID: <875zixqe7d.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <9e41bfdd-c2e6-9fcd-9576-d485aba0d401@redhat.com> (Carlos O'Donell's message of "Tue, 3 Dec 2019 15:47:41 -0500")
* Carlos O'Donell:
> While reviewing bug 25240 I found that -march=486 -Os doesn't build
> with gcc 9.2.1 because of this problem. Fixing is straight forward,
> but I'm not sure if undefining NDEBUG like this is the best solution.
> I wonder if there isn't a pragma we might use here? Thoughts?
-march=i486?
Where does this NDEBUG come from, exactly?
Thanks,
Florian
next prev parent reply other threads:[~2019-12-03 21:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 20:47 Carlos O'Donell
2019-12-03 21:41 ` Florian Weimer [this message]
2019-12-03 22:01 ` [PATCH v2] Fix build with -march=486 -Os -DNDEBUG " Carlos O'Donell
2019-12-04 7:31 ` Florian Weimer
2019-12-04 14:44 ` [PATCH] Fix failure to run tests when CFLAGS contains -DNDEBUG (Bug 25251) Carlos O'Donell
2019-12-04 16:49 ` [PATCH v2] Fix failure " Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zixqe7d.fsf@oldenburg2.str.redhat.com \
--to=fweimer@redhat.com \
--cc=carlos@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).