From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-99257-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 57023 invoked by alias); 15 Jan 2019 10:04:05 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 57009 invoked by uid 89); 15 Jan 2019 10:04:05 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-10.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mx1.redhat.com
From: Florian Weimer <fweimer@redhat.com>
To: Matthew Malcomson <Matthew.Malcomson@arm.com>
Cc: "libc-alpha\@sourceware.org" <libc-alpha@sourceware.org>,  nd <nd@arm.com>
Subject: Re: [Patch] [Makefile] Exit if provided an incorrect argument
References: <VI1PR0801MB20145F5DF9B9E836FB02F5BCE0A10@VI1PR0801MB2014.eurprd08.prod.outlook.com>
Date: Tue, 15 Jan 2019 10:04:00 -0000
In-Reply-To: <VI1PR0801MB20145F5DF9B9E836FB02F5BCE0A10@VI1PR0801MB2014.eurprd08.prod.outlook.com>
	(Matthew Malcomson's message of "Fri, 14 Dec 2018 14:26:24 +0000")
Message-ID: <875zuq6xv9.fsf@oldenburg2.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2019-01/txt/msg00327.txt.bz2

* Matthew Malcomson:

> --- a/Makefile
> +++ b/Makefile
> @@ -148,6 +148,7 @@ while test $$# -gt 0 ; do
>        ;;
>      --*)
>        usage
> +      exit 1
>        ;;
>      *)
>        break

I think you should add the exit to the usage function.

Thanks,
Florian