From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-93491-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 24367 invoked by alias); 20 Jun 2018 22:19:14 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 24226 invoked by uid 89); 20 Jun 2018 22:19:13 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=Hx-languages-length:1065
X-HELO: mx0a-001b2d01.pphosted.com
From: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: libc-alpha@sourceware.org
Cc: 
Subject: Re: [PATCH 03/12] Add a generic scalb implementation
In-Reply-To: <alpine.DEB.2.20.1806202027270.31467@digraph.polyomino.org.uk>
References: <20180620020426.20372-1-tuliom@linux.ibm.com> <20180620020426.20372-4-tuliom@linux.ibm.com> <alpine.DEB.2.20.1806202027270.31467@digraph.polyomino.org.uk>
User-Agent: Notmuch/0.25 (http://notmuchmail.org) Emacs/25.3.1 (x86_64-redhat-linux-gnu)
Date: Wed, 20 Jun 2018 22:19:00 -0000
MIME-Version: 1.0
Content-Type: text/plain
X-TM-AS-GCONF: 00
x-cbid: 18062022-0072-0000-0000-00000372531D
X-IBM-SpamModules-Scores: 
X-IBM-SpamModules-Versions: BY=3.00009229; HX=3.00000241; KW=3.00000007;
 PH=3.00000004; SC=3.00000265; SDB=6.01049902; UDB=6.00538005; IPR=6.00828874;
 MB=3.00021767; MTD=3.00000008; XFM=3.00000015; UTC=2018-06-20 22:19:07
X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused
x-cbparentid: 18062022-0073-0000-0000-0000486E5821
Message-Id: <87602dayp3.fsf@linux.ibm.com>
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-06-20_10:,,
 signatures=0
X-SW-Source: 2018-06/txt/msg00645.txt.bz2

Joseph Myers <joseph@codesourcery.com> writes:

> On Tue, 19 Jun 2018, Tulio Magno Quites Machado Filho wrote:
>
>> Create templates for e_scabl, w_scalb and w_scalb_compat.
>
> I don't think w_scalb_compat should become a template,

Ack.

> just a new w_scalb (with the compat files having all their contents become
> conditional on LIBM_SVID_COMPAT).

float, double and long double define __USE_WRAPPER_TEMPLATE as:
#define __USE_WRAPPER_TEMPLATE !LIBM_SVID_COMPAT

So, I guess the current code is already covering this part.
Am I missing something?

> Then you don't need to do anything with M_K_STANDARD, 
> because __kernel_standard is only used in compat files (and note the 
> arguments passed to it are different numbers for float / double / long 
> double, so M_K_STANDARD in this patch isn't actually correct).  And 
> w_scalbF_compat would stay in libm-compat-calls, so no empty float128 
> version would be needed (whereas an empty float128 version of w_scalb 
> would be needed).

Agreed.

-- 
Tulio Magno