From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) by sourceware.org (Postfix) with ESMTPS id A9FD0388A413 for ; Tue, 22 Dec 2020 19:05:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A9FD0388A413 Received: by mail-qk1-x72d.google.com with SMTP id w79so12843312qkb.5 for ; Tue, 22 Dec 2020 11:05:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:autocrypt:subject :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=ARlY19D8b++HTZMY/bu9oIHe4QokNGAwU9AfExXLKSg=; b=HiJRyAeXHiH5F0mB5dRE5E26pAKIdiZg9w7QPnR0Gz9JHzjJvVDIlPQV/Tlr/ag02O v8VwkCFbIhADil/rAyad6HVTotwyLRAHBu6QVHrriqxeP1REHx7PRhhDA4ZHpVKjGdTk viHT0bgTFCxRUtIJD6Pf+KoSPmQTRSKC/VAqLZHTscf0hB66eZnWoWyBl4eqMaLr1vjZ lbiaF0ZChdIFJw2uml4okln9Pqz5kpnmpkZ2vQqqHrUGvWSJ9fzQAQkyRMg1zdbz2Lhm W02X0YMH+0F9hS70vucWEqKTr5AoCnqeTjd6tgmvNr3bP284KeQOEtCHMlJzkgGWk4uV Gk2Q== X-Gm-Message-State: AOAM533bndBBorO7seW2czlQ6eIcqQqxfh5Vfebs7VpV5A7K5efvTlh+ Y1KcBxHmW0eL3UhVz4baO4R4DQ== X-Google-Smtp-Source: ABdhPJyx5+JbnTOjyHLEKsJSm1Z1+K9+46pTzU45URv1F8HLZZ4IHl87b279civUM0cN876NQyOdPg== X-Received: by 2002:a37:9fc6:: with SMTP id i189mr23150378qke.41.1608663901099; Tue, 22 Dec 2020 11:05:01 -0800 (PST) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id j29sm12630879qtv.11.2020.12.22.11.04.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Dec 2020 11:05:00 -0800 (PST) To: Siddhesh Poyarekar , libc-alpha@sourceware.org Cc: fweimer@redhat.com, joseph@codesourcery.com References: <20201215141339.2684384-1-siddhesh@sourceware.org> <20201215141339.2684384-3-siddhesh@sourceware.org> From: Adhemerval Zanella Autocrypt: addr=adhemerval.zanella@linaro.org; prefer-encrypt=mutual; keydata= mQINBFcVGkoBEADiQU2x/cBBmAVf5C2d1xgz6zCnlCefbqaflUBw4hB/bEME40QsrVzWZ5Nq 8kxkEczZzAOKkkvv4pRVLlLn/zDtFXhlcvQRJ3yFMGqzBjofucOrmdYkOGo0uCaoJKPT186L NWp53SACXguFJpnw4ODI64ziInzXQs/rUJqrFoVIlrPDmNv/LUv1OVPKz20ETjgfpg8MNwG6 iMizMefCl+RbtXbIEZ3TE/IaDT/jcOirjv96lBKrc/pAL0h/O71Kwbbp43fimW80GhjiaN2y WGByepnkAVP7FyNarhdDpJhoDmUk9yfwNuIuESaCQtfd3vgKKuo6grcKZ8bHy7IXX1XJj2X/ BgRVhVgMHAnDPFIkXtP+SiarkUaLjGzCz7XkUn4XAGDskBNfbizFqYUQCaL2FdbW3DeZqNIa nSzKAZK7Dm9+0VVSRZXP89w71Y7JUV56xL/PlOE+YKKFdEw+gQjQi0e+DZILAtFjJLoCrkEX w4LluMhYX/X8XP6/C3xW0yOZhvHYyn72sV4yJ1uyc/qz3OY32CRy+bwPzAMAkhdwcORA3JPb kPTlimhQqVgvca8m+MQ/JFZ6D+K7QPyvEv7bQ7M+IzFmTkOCwCJ3xqOD6GjX3aphk8Sr0dq3 4Awlf5xFDAG8dn8Uuutb7naGBd/fEv6t8dfkNyzj6yvc4jpVxwARAQABtElBZGhlbWVydmFs IFphbmVsbGEgTmV0dG8gKExpbmFybyBWUE4gS2V5KSA8YWRoZW1lcnZhbC56YW5lbGxhQGxp bmFyby5vcmc+iQI3BBMBCAAhBQJXFRpKAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKqx7BSnlIjv0e8P/1YOYoNkvJ+AJcNUaM5a2SA9oAKjSJ/M/EN4Id5Ow41ZJS4lUA0apSXW NjQg3VeVc2RiHab2LIB4MxdJhaWTuzfLkYnBeoy4u6njYcaoSwf3g9dSsvsl3mhtuzm6aXFH /Qsauav77enJh99tI4T+58rp0EuLhDsQbnBic/ukYNv7sQV8dy9KxA54yLnYUFqH6pfH8Lly sTVAMyi5Fg5O5/hVV+Z0Kpr+ZocC1YFJkTsNLAW5EIYSP9ftniqaVsim7MNmodv/zqK0IyDB GLLH1kjhvb5+6ySGlWbMTomt/or/uvMgulz0bRS+LUyOmlfXDdT+t38VPKBBVwFMarNuREU2 69M3a3jdTfScboDd2ck1u7l+QbaGoHZQ8ZNUrzgObltjohiIsazqkgYDQzXIMrD9H19E+8fw kCNUlXxjEgH/Kg8DlpoYJXSJCX0fjMWfXywL6ZXc2xyG/hbl5hvsLNmqDpLpc1CfKcA0BkK+ k8R57fr91mTCppSwwKJYO9T+8J+o4ho/CJnK/jBy1pWKMYJPvvrpdBCWq3MfzVpXYdahRKHI ypk8m4QlRlbOXWJ3TDd/SKNfSSrWgwRSg7XCjSlR7PNzNFXTULLB34sZhjrN6Q8NQZsZnMNs TX8nlGOVrKolnQPjKCLwCyu8PhllU8OwbSMKskcD1PSkG6h3r0AquQINBFcVGkoBEACgAdbR Ck+fsfOVwT8zowMiL3l9a2DP3Eeak23ifdZG+8Avb/SImpv0UMSbRfnw/N81IWwlbjkjbGTu oT37iZHLRwYUFmA8fZX0wNDNKQUUTjN6XalJmvhdz9l71H3WnE0wneEM5ahu5V1L1utUWTyh VUwzX1lwJeV3vyrNgI1kYOaeuNVvq7npNR6t6XxEpqPsNc6O77I12XELic2+36YibyqlTJIQ V1SZEbIy26AbC2zH9WqaKyGyQnr/IPbTJ2Lv0dM3RaXoVf+CeK7gB2B+w1hZummD21c1Laua +VIMPCUQ+EM8W9EtX+0iJXxI+wsztLT6vltQcm+5Q7tY+HFUucizJkAOAz98YFucwKefbkTp eKvCfCwiM1bGatZEFFKIlvJ2QNMQNiUrqJBlW9nZp/k7pbG3oStOjvawD9ZbP9e0fnlWJIsj 6c7pX354Yi7kxIk/6gREidHLLqEb/otuwt1aoMPg97iUgDV5mlNef77lWE8vxmlY0FBWIXuZ yv0XYxf1WF6dRizwFFbxvUZzIJp3spAao7jLsQj1DbD2s5+S1BW09A0mI/1DjB6EhNN+4bDB SJCOv/ReK3tFJXuj/HbyDrOdoMt8aIFbe7YFLEExHpSk+HgN05Lg5TyTro8oW7TSMTk+8a5M kzaH4UGXTTBDP/g5cfL3RFPl79ubXwARAQABiQIfBBgBCAAJBQJXFRpKAhsMAAoJEKqx7BSn lIjvI/8P/jg0jl4Tbvg3B5kT6PxJOXHYu9OoyaHLcay6Cd+ZrOd1VQQCbOcgLFbf4Yr+rE9l mYsY67AUgq2QKmVVbn9pjvGsEaz8UmfDnz5epUhDxC6yRRvY4hreMXZhPZ1pbMa6A0a/WOSt AgFj5V6Z4dXGTM/lNManr0HjXxbUYv2WfbNt3/07Db9T+GZkpUotC6iknsTA4rJi6u2ls0W9 1UIvW4o01vb4nZRCj4rni0g6eWoQCGoVDk/xFfy7ZliR5B+3Z3EWRJcQskip/QAHjbLa3pml xAZ484fVxgeESOoaeC9TiBIp0NfH8akWOI0HpBCiBD5xaCTvR7ujUWMvhsX2n881r/hNlR9g fcE6q00qHSPAEgGr1bnFv74/1vbKtjeXLCcRKk3Ulw0bY1OoDxWQr86T2fZGJ/HIZuVVBf3+ gaYJF92GXFynHnea14nFFuFgOni0Mi1zDxYH/8yGGBXvo14KWd8JOW0NJPaCDFJkdS5hu0VY 7vJwKcyHJGxsCLU+Et0mryX8qZwqibJIzu7kUJQdQDljbRPDFd/xmGUFCQiQAncSilYOcxNU EMVCXPAQTteqkvA+gNqSaK1NM9tY0eQ4iJpo+aoX8HAcn4sZzt2pfUB9vQMTBJ2d4+m/qO6+ cFTAceXmIoFsN8+gFN3i8Is3u12u8xGudcBPvpoy4OoG Subject: Re: [PATCH 2/5] x86 long double: Support pseudo numbers in isnanl Message-ID: <87729898-7aad-7eaf-0940-e35dbc69a44d@linaro.org> Date: Tue, 22 Dec 2020 16:04:57 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201215141339.2684384-3-siddhesh@sourceware.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-15.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Dec 2020 19:05:03 -0000 On 15/12/2020 11:13, Siddhesh Poyarekar via Libc-alpha wrote: > Sync up with gcc behaviour. This change splits out the core isnanl > logic so that it can be reused. > --- > sysdeps/i386/fpu/s_isnanl.c | 10 ++-------- > sysdeps/x86/fpu/isnanl_common.h | 32 ++++++++++++++++++++++++++++++++ > 2 files changed, 34 insertions(+), 8 deletions(-) > create mode 100644 sysdeps/x86/fpu/isnanl_common.h > > diff --git a/sysdeps/i386/fpu/s_isnanl.c b/sysdeps/i386/fpu/s_isnanl.c > index fb97317bc9..6824f31d96 100644 > --- a/sysdeps/i386/fpu/s_isnanl.c > +++ b/sysdeps/i386/fpu/s_isnanl.c > @@ -25,19 +25,13 @@ static char rcsid[] = "$NetBSD: $"; > > #include > #include > +#include "sysdeps/x86/fpu/isnanl_common.h" > > int __isnanl(long double x) > { > int32_t se,hx,lx; > GET_LDOUBLE_WORDS(se,hx,lx,x); > - se = (se & 0x7fff) << 1; > - /* The additional & 0x7fffffff is required because Intel's > - extended format has the normally implicit 1 explicit > - present. Sigh! */ > - lx |= hx & 0x7fffffff; > - se |= (uint32_t)(lx|(-lx))>>31; > - se = 0xfffe - se; > - return (int)((uint32_t)(se))>>16; > + return x86_isnanl (se, hx, lx); > } > hidden_def (__isnanl) > weak_alias (__isnanl, isnanl) As for fpclassify, I think a better strategy would to move this code to sysdeps/x86/fpu. > diff --git a/sysdeps/x86/fpu/isnanl_common.h b/sysdeps/x86/fpu/isnanl_common.h > new file mode 100644 > index 0000000000..60a4af5b41 > --- /dev/null > +++ b/sysdeps/x86/fpu/isnanl_common.h > @@ -0,0 +1,32 @@ > +/* Common inline isnanl implementation for x86. > + Copyright (C) 2020 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library; if not, see > + . */ > + > +static inline __always_inline int > +x86_isnanl (int32_t se, int32_t hx, int32_t lx) > +{ > + se = (se & 0x7fff) << 1; > + /* Detect pseudo-normal numbers, i.e. exponent is non-zero and the top > + bit of the significand is not set. */ This sentence sounds strange, would 'if' instead of 'of' be better? > + int pn = (uint32_t)((~hx & 0x80000000) & (se | (-se))) >> 31; Ok. > + /* Clear the significand bit when computing mantissa. */ > + lx |= hx & 0x7fffffff; > + se |= (uint32_t)(lx | (-lx)) >> 31; > + se = 0xfffe - se; > + > + return (int)(((uint32_t)(se)) >> 16) | pn; > +} > Not sure if this is really a gain here, is this routine really worth to move to inline instead of just calling the __isnanl (since it seems to be used solely on issignalingl)?