From: Florian Weimer <fweimer@redhat.com>
To: "Cristian Rodríguez" <cristian@rodriguez.im>
Cc: Wilco Dijkstra <Wilco.Dijkstra@arm.com>,
Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>,
"libc-alpha@sourceware.org" <libc-alpha@sourceware.org>,
Cupertino Miranda <cupertino.miranda@oracle.com>
Subject: Re: [PATCH] nptl: Disable THP on thread stack if it incurs in large RSS usage
Date: Wed, 31 Jan 2024 08:54:40 +0100 [thread overview]
Message-ID: <877cjqym2n.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <CAPBLoAcntaNtdXqKH4XbcoXfFex4meKsuAAz5TkJcq7HgELaKw@mail.gmail.com> ("Cristian =?utf-8?Q?Rodr=C3=ADguez=22's?= message of "Tue, 30 Jan 2024 23:03:44 -0300")
* Cristian Rodríguez:
> On Tue, May 23, 2023 at 5:48 AM Wilco Dijkstra via Libc-alpha <libc-alpha@sourceware.org>
> wrote:
>
>> However even switching off THP for all small stacks (eg. default size or smaller)
>> would avoid the random use of THP without needing to set the tunable.
>>
>> Cheers,
>> Wilco
>
>
> Didn't found the exact message to reply.. but this one is close enough. MAP_STACK implies no
> transparent hugepages since linux kernel commit
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c4608d1bf7c6536d1a3d233eb21e50678681564e
It's an odd choice for fixing the regression. I commented on the
linux-mm thread. It's also surprising to see such changes being made
without larger discussion.
Thanks,
Florian
next prev parent reply other threads:[~2024-01-31 7:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 17:24 Adhemerval Zanella
2023-05-03 12:42 ` Wilco Dijkstra
2023-05-15 17:57 ` Adhemerval Zanella Netto
2023-05-16 15:38 ` Wilco Dijkstra
2023-05-16 16:35 ` Adhemerval Zanella Netto
2023-05-17 12:49 ` Wilco Dijkstra
2023-05-17 13:12 ` Cupertino Miranda
2023-05-17 13:20 ` Adhemerval Zanella Netto
2023-05-17 14:22 ` Wilco Dijkstra
2023-05-17 16:50 ` Adhemerval Zanella Netto
2023-05-17 18:16 ` Wilco Dijkstra
2023-05-18 13:04 ` Adhemerval Zanella Netto
2023-05-23 9:48 ` Wilco Dijkstra
2024-01-31 2:03 ` Cristian Rodríguez
2024-01-31 7:54 ` Florian Weimer [this message]
2024-01-31 11:30 ` Adhemerval Zanella Netto
2024-01-31 11:43 ` Florian Weimer
2024-03-12 0:55 ` Cristian Rodríguez
2024-01-31 15:18 ` Cristian Rodríguez
2024-02-01 1:26 ` Cristian Rodríguez
2023-05-16 14:30 ` Cupertino Miranda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cjqym2n.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=Wilco.Dijkstra@arm.com \
--cc=adhemerval.zanella@linaro.org \
--cc=cristian@rodriguez.im \
--cc=cupertino.miranda@oracle.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).