From: Florian Weimer <fweimer@redhat.com>
To: Carlos O'Donell <carlos@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH 1/3] elf: Record main program constructor/destructor in ordering tests
Date: Tue, 19 Sep 2023 16:41:00 +0200 [thread overview]
Message-ID: <877comgr9f.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <43320ed7-13b8-743e-77d6-c39250a9f6ae@redhat.com> (Carlos O'Donell's message of "Tue, 19 Sep 2023 10:24:53 -0400")
* Carlos O'Donell:
> On 9/19/23 08:47, Florian Weimer wrote:
>> * Carlos O'Donell:
>>
>>> On 9/19/23 04:48, Florian Weimer wrote:
>>>> Previously, the ordering was not capture in the test output. Adjust
>>>
>>> s/capture/captured/g (as noted by Andreas)
>>>
>>>> expected test output accordingly. Note that after commit 6985865bc3a
>>>> ("elf: Always call destructors in reverse constructor order
>>>> (bug 30785)"), the main program destructors in tst-bz28937 run last
>>>> (which is bug XXX).
>>>
>>> Do we need to fill in bug XXX?
>>
>> It's bug 30869, I just forgot to update the commit message.
>
> Perfect.
>
> Let me finish reviewing 3/3 and then we can proceed with a light review
> of v2 with the cleanups?
Works for me, thanks.
Florian
next prev parent reply other threads:[~2023-09-19 14:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 8:48 [PATCH 0/3] Fine-tune ELF destructor ordering (bug 30869) Florian Weimer
2023-09-19 8:48 ` [PATCH 1/3] elf: Record main program constructor/destructor in ordering tests Florian Weimer
2023-09-19 8:56 ` Andreas Schwab
2023-09-19 9:30 ` Florian Weimer
2023-09-19 12:41 ` Carlos O'Donell
2023-09-19 12:47 ` Florian Weimer
2023-09-19 14:24 ` Carlos O'Donell
2023-09-19 14:41 ` Florian Weimer [this message]
2023-09-19 8:48 ` [PATCH 2/3] elf: Add dummy declaration of _dl_audit_objclose for !SHARED Florian Weimer
2023-09-19 12:43 ` Carlos O'Donell
2023-09-19 8:48 ` [PATCH 3/3] elf: Process initially loaded objects first in _dl_fini (bug 30869) Florian Weimer
2023-10-06 12:35 ` [PATCH 0/3] Fine-tune ELF destructor ordering " Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877comgr9f.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=carlos@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).