From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 973103858D20 for ; Tue, 19 Sep 2023 14:41:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 973103858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695134464; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=b2VfIuGtbbw05C1eIB7NW9AgHG/K2zxT3ygqNbsNh7I=; b=iuCW+QKxCi79SLEWnypHpvYDrqGv0LljITx4GVVGy2HzSlJ2SomoCEqrQ23CLMQxpv/h8E KPt0UC0k0ZyoodvzZzTdoPwxvoSYUHXpd7nA7TXiibMoYhWXNN0x8yWLamAAVUvBUqOL+F sYlTypX6qI4uT08MZOKPePd2wThdJRY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-146-C27kS7MeMbOte7A2A4JB5Q-1; Tue, 19 Sep 2023 10:41:03 -0400 X-MC-Unique: C27kS7MeMbOte7A2A4JB5Q-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6EDA318175A3 for ; Tue, 19 Sep 2023 14:41:02 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.101]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E82FC492B16; Tue, 19 Sep 2023 14:41:01 +0000 (UTC) From: Florian Weimer To: Carlos O'Donell Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 1/3] elf: Record main program constructor/destructor in ordering tests References: <7956993aec569453b3d537dffbfd7962f159a3b6.1695113064.git.fweimer@redhat.com> <4c6eca31-175a-9e60-613f-1f827ddc9334@redhat.com> <87h6nquy6r.fsf@oldenburg.str.redhat.com> <43320ed7-13b8-743e-77d6-c39250a9f6ae@redhat.com> Date: Tue, 19 Sep 2023 16:41:00 +0200 In-Reply-To: <43320ed7-13b8-743e-77d6-c39250a9f6ae@redhat.com> (Carlos O'Donell's message of "Tue, 19 Sep 2023 10:24:53 -0400") Message-ID: <877comgr9f.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Carlos O'Donell: > On 9/19/23 08:47, Florian Weimer wrote: >> * Carlos O'Donell: >> >>> On 9/19/23 04:48, Florian Weimer wrote: >>>> Previously, the ordering was not capture in the test output. Adjust >>> >>> s/capture/captured/g (as noted by Andreas) >>> >>>> expected test output accordingly. Note that after commit 6985865bc3a >>>> ("elf: Always call destructors in reverse constructor order >>>> (bug 30785)"), the main program destructors in tst-bz28937 run last >>>> (which is bug XXX). >>> >>> Do we need to fill in bug XXX? >> >> It's bug 30869, I just forgot to update the commit message. > > Perfect. > > Let me finish reviewing 3/3 and then we can proceed with a light review > of v2 with the cleanups? Works for me, thanks. Florian