From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=pn0M=7C=redhat.com=fweimer@sourceware.org>
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
	by sourceware.org (Postfix) with ESMTPS id 9A58A3858409
	for <libc-alpha@sourceware.org>; Fri, 10 Mar 2023 16:49:33 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9A58A3858409
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1678466973;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=5o0DRKSe7BbTY+8BGLEZr9etZTECTEK9ouSTj/+pSVk=;
	b=EYz/jE3IrZVvslZO45JGmbBAQvzLCC2Mbsw9mbRbKJ3MwuqrJ4zwFDo0BiQmfCDzGQtiJn
	9CRjnO4jhLxGinKzb0JK2wekvbudz9Zo77xnly0FFde0fjXKIDYLClvD5ZuYmjCX86kDa8
	NgBfzdJK25dBDRgyWAjWPq8TLkIauGQ=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-508-BkuWIiyaNsub2yQ3ENnAeA-1; Fri, 10 Mar 2023 11:49:32 -0500
X-MC-Unique: BkuWIiyaNsub2yQ3ENnAeA-1
Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9D6D4857A8E;
	Fri, 10 Mar 2023 16:49:31 +0000 (UTC)
Received: from oldenburg.str.redhat.com (unknown [10.2.16.4])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 80CEA492B04;
	Fri, 10 Mar 2023 16:49:30 +0000 (UTC)
From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org,  "Andreas K . Huettel"
 <dilfridge@gentoo.org>,  Paul Eggert <eggert@cs.ucla.edu>
Subject: Re: [PATCH v6 2/3] support: Add xreallocarray
References: <20230302145732.2293756-1-adhemerval.zanella@linaro.org>
	<20230302145732.2293756-3-adhemerval.zanella@linaro.org>
Date: Fri, 10 Mar 2023 17:49:28 +0100
In-Reply-To: <20230302145732.2293756-3-adhemerval.zanella@linaro.org>
	(Adhemerval Zanella's message of "Thu, 2 Mar 2023 11:57:31 -0300")
Message-ID: <877cvoa6w7.fsf@oldenburg.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libc-alpha.sourceware.org>

* Adhemerval Zanella:

> +void *
> +xreallocarray (void *p, size_t n, size_t s)
> +{
> +  void *r = reallocarray (p, n, s);
> +  if (r == NULL)
> +    oom_error ("reallocarray", n);
> +  return r;
> +}

Isn't the failure condition more complicated?  See xrealloc.

Thanks,
Florian