From: Florian Weimer <fweimer@redhat.com>
To: "Yago Gutiérrez via Libc-alpha" <libc-alpha@sourceware.org>
Cc: "Yago Gutiérrez" <yagogl@protonmail.com>
Subject: Re: [PATCH 0/1] __libc_start_main() now uses auxv to obtain phdr's address [BZ #29864]
Date: Thu, 08 Dec 2022 19:54:54 +0100 [thread overview]
Message-ID: <877cz1hgjl.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <73l3eC0YTCoWnmm2zGV-SIY9-W5DQ-peyx7secTao121qocwqub-R4Zhrpkai8_LRxy4xsn7ARdHRbI7NnzSysk6ACmQWfiavdpz-tA70xc=@protonmail.com> ("Yago =?utf-8?Q?Guti=C3=A9rrez?= via Libc-alpha"'s message of "Wed, 07 Dec 2022 12:16:33 +0000")
* Yago Gutiérrez via Libc-alpha:
> From bf2371ce732194f652719aff4af0f9021f9cbd90 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Yago=20Guti=C3=A9rrez?= <yagogl@protonmail.com>
> Date: Wed, 7 Dec 2022 12:49:22 +0100
> Subject: [PATCH 1/1] __libc_start_main() now uses auxv to obtain phdr's
> address [BZ #29864]
> To: libc-alpha@sourceware.org
This needs a much more elaborate commit message.
I don't quite get why you need to add this to _rtld_global. This is
only used by the static startup code.
This looks like it is a fix for the refactoring in:
commit 73fc4e28b9464f0e13edc719a5372839970e7ddb
Author: Florian Weimer <fweimer@redhat.com>
Date: Mon Feb 28 11:50:41 2022 +0100
Linux: Consolidate auxiliary vector parsing (redo)
And optimize it slightly.
This is commit 8c8510ab2790039e58995ef3a22309582413d3ff revised.
In _dl_aux_init in elf/dl-support.c, use an explicit loop
and -fno-tree-loop-distribute-patterns to avoid memset.
Reviewed-by: Szabolcs Nagy <szabolcs.nagy@arm.com>
What are the actual failures you see?
Thanks,
Florian
next prev parent reply other threads:[~2022-12-08 18:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 12:16 Yago Gutiérrez
2022-12-08 17:07 ` Adhemerval Zanella
2022-12-08 18:42 ` Florian Weimer
2022-12-08 18:54 ` Florian Weimer [this message]
2022-12-08 19:15 ` Adhemerval Zanella Netto
2022-12-09 9:02 ` Yago Gutiérrez
[not found] ` <Zh0QVJP4RDa4zdV2FwJIKo4bZwKIHjPNcx_A8J7KIg24u5hoGj9lXet5H4FiLvVNPg4zAErbNQkuNnUnSBkhEXiLAnBjs5SUFKtN-x9fR5U=@protonmail.com>
2022-12-09 13:13 ` Florian Weimer
2022-12-09 13:50 ` Adhemerval Zanella Netto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cz1hgjl.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=yagogl@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).