public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Palmer Dabbelt <palmer@dabbelt.com>
Cc: joseph@codesourcery.com,  libc-alpha@sourceware.org
Subject: Re: Update syscall lists for Linux 5.19
Date: Fri, 05 Aug 2022 17:56:53 +0200	[thread overview]
Message-ID: <877d3m1y62.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <Yu0saPOzEnCNgt+z@aurel32.net> (Aurelien Jarno's message of "Fri,  5 Aug 2022 16:42:48 +0200")

* Aurelien Jarno:

> On 2022-08-03 17:36, Palmer Dabbelt wrote:
>> On Tue, 02 Aug 2022 12:23:42 PDT (-0700), joseph@codesourcery.com wrote:
>> > Linux 5.19 has no new syscalls, but enables memfd_secret in the uapi
>> > headers for RISC-V.  Update the version number in syscall-names.list
>> > to reflect that it is still current for 5.19 and regenerate the
>> > arch-syscall.h headers with build-many-glibcs.py update-syscalls.
>> > 
>> > Tested with build-many-glibcs.py.
>> > 
>> > diff --git a/sysdeps/unix/sysv/linux/riscv/rv32/arch-syscall.h b/sysdeps/unix/sysv/linux/riscv/rv32/arch-syscall.h
>> > index bf4be80..202520e 100644
>> > --- a/sysdeps/unix/sysv/linux/riscv/rv32/arch-syscall.h
>> > +++ b/sysdeps/unix/sysv/linux/riscv/rv32/arch-syscall.h
>> > @@ -122,6 +122,7 @@
>> >  #define __NR_mbind 235
>> >  #define __NR_membarrier 283
>> >  #define __NR_memfd_create 279
>> > +#define __NR_memfd_secret 447
>> >  #define __NR_migrate_pages 238
>> >  #define __NR_mincore 232
>> >  #define __NR_mkdirat 34
>> > diff --git a/sysdeps/unix/sysv/linux/riscv/rv64/arch-syscall.h b/sysdeps/unix/sysv/linux/riscv/rv64/arch-syscall.h
>> > index d656aed..4e65f33 100644
>> > --- a/sysdeps/unix/sysv/linux/riscv/rv64/arch-syscall.h
>> > +++ b/sysdeps/unix/sysv/linux/riscv/rv64/arch-syscall.h
>> > @@ -127,6 +127,7 @@
>> >  #define __NR_mbind 235
>> >  #define __NR_membarrier 283
>> >  #define __NR_memfd_create 279
>> > +#define __NR_memfd_secret 447
>> >  #define __NR_migrate_pages 238
>> >  #define __NR_mincore 232
>> >  #define __NR_mkdirat 34
>> > diff --git a/sysdeps/unix/sysv/linux/syscall-names.list b/sysdeps/unix/sysv/linux/syscall-names.list
>> > index 6c7b2f7..028ad31 100644
>> > --- a/sysdeps/unix/sysv/linux/syscall-names.list
>> > +++ b/sysdeps/unix/sysv/linux/syscall-names.list
>> > @@ -21,8 +21,8 @@
>> >  # This file can list all potential system calls.  The names are only
>> >  # used if the installed kernel headers also provide them.
>> > 
>> > -# The list of system calls is current as of Linux 5.18.
>> > -kernel 5.18
>> > +# The list of system calls is current as of Linux 5.19.
>> > +kernel 5.19
>> > 
>> >  FAST_atomic_update
>> >  FAST_cmpxchg
>> 
>> Thanks, this was just a bug in the uapi headers: the syscall itself was has
>> been implemented since 7bb7f2ac24a0 ("arch, mm: wire up memfd_secret system
>> call where relevant"), which IIUC was first released in 5.14.  The fix
>> should get backported.
>
> It got backported in 5.18.3.

Ohh.

>> I don't think any of that matters so much here, though.
>
> The backport causes the misc/tst-glibcsyscalls test to fail on the
> stable branches (tested on 2.35, but I guess it's the same on 2.36):
>
> | original exit status 1
> | error: kernel syscall 'memfd_secret' (447) not known to glibc
> | info: glibc tables are based on kernel version 5.18
> | info: installed kernel headers are version 5.18
>
> So I wonder if we should just backport this commit to the stable
> branches to fix this failure.

Yes, then we should backport these syscall updates.

Thanks,
Florian


  reply	other threads:[~2022-08-05 15:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-02 19:23 Joseph Myers
2022-08-02 21:01 ` Florian Weimer
2022-08-04  0:36 ` Palmer Dabbelt
2022-08-04  6:58   ` Florian Weimer
2022-08-05 14:42   ` Aurelien Jarno
2022-08-05 15:56     ` Florian Weimer [this message]
2022-08-05 17:28     ` Palmer Dabbelt
2022-08-05 21:44       ` Aurelien Jarno
2022-08-06 18:15         ` Palmer Dabbelt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877d3m1y62.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=joseph@codesourcery.com \
    --cc=libc-alpha@sourceware.org \
    --cc=palmer@dabbelt.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).