From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 231613857375 for ; Wed, 4 May 2022 09:36:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 231613857375 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-423-1pBtHScCOdmHgtriT_UPTQ-1; Wed, 04 May 2022 05:36:18 -0400 X-MC-Unique: 1pBtHScCOdmHgtriT_UPTQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E2F8E1C14C07; Wed, 4 May 2022 09:33:10 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 44292C53360; Wed, 4 May 2022 09:33:10 +0000 (UTC) From: Florian Weimer To: Szabolcs Nagy via Libc-alpha Cc: Szabolcs Nagy Subject: Re: [PATCH v4 4/4] aarch64: Move ld.so _start to separate file and drop _dl_skip_args References: <04cfa0c448fe88a5fd9895b65c4b8f15de63cda3.1651643916.git.szabolcs.nagy@arm.com> Date: Wed, 04 May 2022 11:33:08 +0200 In-Reply-To: <04cfa0c448fe88a5fd9895b65c4b8f15de63cda3.1651643916.git.szabolcs.nagy@arm.com> (Szabolcs Nagy via Libc-alpha's message of "Wed, 4 May 2022 07:27:16 +0100") Message-ID: <877d71tzfv.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 May 2022 09:36:23 -0000 * Szabolcs Nagy via Libc-alpha: > A separate asm file is easier to maintain than a macro that expands to > inline asm. > > The RTLD_START macro is only needed now because _dl_start is local in > rtld.c, but _start has to call it, if _dl_start was made hidden then it > could be empty. > > _dl_skip_args is no longer needed. Still looks okay. Thanks, Florian