From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [IPv6:2001:a60:0:28:0:1:25:1]) by sourceware.org (Postfix) with ESMTPS id 0FEAA385803D for ; Fri, 4 Mar 2022 12:43:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0FEAA385803D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nefkom.net Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4K96wJ3cSBz1s75P; Fri, 4 Mar 2022 13:43:28 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4K96wJ359jz1qqkB; Fri, 4 Mar 2022 13:43:28 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id HMFiK7yKlSpl; Fri, 4 Mar 2022 13:43:26 +0100 (CET) X-Auth-Info: plOR6BJptPajXFtZvA0T+BWeRAxpyVTUKSFO0jmvFqTGMF1BiAamoJw7iCamuGMb Received: from igel.home (ppp-46-244-178-203.dynamic.mnet-online.de [46.244.178.203]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 4 Mar 2022 13:43:26 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id EE4FB2C368F; Fri, 4 Mar 2022 13:43:25 +0100 (CET) From: Andreas Schwab To: Adhemerval Zanella via Libc-alpha Cc: Florian Weimer , Adhemerval Zanella Subject: Re: [PATCH v4] elf: Fix DFS sorting algorithm for LD_TRACE_LOADED_OBJECTS with missing libraries (BZ #28868) References: <20220304120201.363600-1-adhemerval.zanella@linaro.org> X-Yow: .. I have a VISION! It's a RANCID double-FISHWICH on an ENRICHED BUN!! Date: Fri, 04 Mar 2022 13:43:25 +0100 In-Reply-To: <20220304120201.363600-1-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Fri, 4 Mar 2022 09:02:01 -0300") Message-ID: <877d99lwgi.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Mar 2022 12:43:31 -0000 On Mär 04 2022, Adhemerval Zanella via Libc-alpha wrote: > @@ -2725,3 +2735,50 @@ $(objpfx)tst-p_align3: $(objpfx)tst-p_alignmod3.so > $(objpfx)tst-p_align3.out: tst-p_align3.sh $(objpfx)tst-p_align3 > $(SHELL) $< $(common-objpfx) '$(test-program-prefix)'; \ > $(evaluate-test) > + > + > +# Move the library to a folder so it can be selected by --library-path > +define libtracemod-mv > + test -d $(objpfx)libtracemod$(1) || mkdir $(objpfx)libtracemod$(1) You can use mkdir -p, which avoids any races. > + test -f $(objpfx)libtracemod$(1).so \ > + && mv $(objpfx)libtracemod$(1).so $(objpfx)libtracemod$(1) This will result in a non-zero status if $(objpfx)libtracemod$(1).so doesn't exist, causing the command to fail. It's also not race-free. > +define tst-trace-skeleton > +$(objpfx)tst-trace$(1).out: $(..)scripts/tst-ld-trace.py \ > + $(objpfx)libtracemod1.so \ > + libtracemod-mv \ > + tst-trace$(1).exp The dependency on the phony libtracemod-mv will cause the command to always be rerun. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."