From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id E956E3858C83 for ; Tue, 1 Mar 2022 12:42:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E956E3858C83 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-458-8riIPRBsPPK1FCdoASapQg-1; Tue, 01 Mar 2022 07:42:08 -0500 X-MC-Unique: 8riIPRBsPPK1FCdoASapQg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B1B11801AB2; Tue, 1 Mar 2022 12:42:06 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.193.76]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0D99C7887B; Tue, 1 Mar 2022 12:42:04 +0000 (UTC) From: Florian Weimer To: Samuel Thibault Cc: Adhemerval Zanella , libc-alpha@sourceware.org Subject: Re: [hurd] update-abi References: <20220127141400.3364940-1-adhemerval.zanella@linaro.org> <87h79pma45.fsf@oldenburg.str.redhat.com> <6fc49d07-940d-a356-aebd-5b0de8c681f0@linaro.org> <20220127171557.kseob4ysn5tgcsg4@begin> <9cba4ff5-49c6-e597-85f5-45be0021bfa7@linaro.org> <20220128000731.ri4cbzkoxmyrft5o@begin> Date: Tue, 01 Mar 2022 13:42:03 +0100 In-Reply-To: <20220128000731.ri4cbzkoxmyrft5o@begin> (Samuel Thibault's message of "Fri, 28 Jan 2022 01:07:31 +0100") Message-ID: <877d9dondw.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Mar 2022 12:42:13 -0000 * Samuel Thibault: > Adhemerval Zanella, le jeu. 27 janv. 2022 15:09:29 -0300, a ecrit: >> On 27/01/2022 14:15, Samuel Thibault wrote: >> > Adhemerval Zanella via Libc-alpha, le jeu. 27 janv. 2022 14:04:28 -0300, a ecrit: >> >> On 27/01/2022 13:11, Florian Weimer wrote: >> >>> * Adhemerval Zanella: >> >>> >> >>>> The posix_spawnattr_tcsetpgrp_np works on a file descriptor (the >> >>>> controlling terminal), so it would make more sense to actually fit >> >>>> it on the file actions API. >> >>>> >> >>>> Also, POSIX_SPAWN_TCSETPGROUP is not really required since it is >> >>>> implicit by the presence of tcsetpgrp file action. >> >>>> >> >>>> The posix/tst-spawn6.c is also fixed when TTY can is not present. >> >>>> >> >>>> Checked on x86_64-linux-gnu and i686-linux-gnu. >> >>> >> >>> This has an ABI check failure on Hurd: >> >>> >> >>> --- ../sysdeps/mach/hurd/i386/libc.abilist 2022-01-27 10:04:20.120812828 -0500 >> >>> +++ /home/bmg/build/glibcs/i686-gnu/glibc/libc.symlist 2022-01-27 10:43:39.646804376 -0500 >> >>> @@ -2292,2 +2291,0 @@ GLIBC_2.35 posix_spawn_file_actions_addt >> >>> -GLIBC_2.35 posix_spawnattr_tcgetpgrp_np F >> >>> -GLIBC_2.35 posix_spawnattr_tcsetpgrp_np F >> >>> >> >>> The changes look okay to me. A second review is probably warranted at >> >>> this stage. >> >> >> >> Thanks. It is really annoying that hurd make update-abi adds a bunch of files >> >> and requires manual edit to get it right. >> > >> > I don't think I understand. How is it different in the linux case? >> >> A 'make update-abi' with a default 'configure --prefix=/usr' creates two >> files on source: > >> modified: sysdeps/mach/hurd/libhurduser.abilist >> modified: sysdeps/mach/libmachuser.abilist > > Ok, would the attached patch be ok? We do not track ABI on these libs. Why is there no tracking? Should they use GLIBC_PRIVATE symbols only then? Thanks, Florian