From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Cc: "H . J . Lu" <hjl.tools@gmail.com>,
Carlos O'Donell <carlos@redhat.com>,
Joseph Myers <joseph@codesourcery.com>,
Adhemerval Zanella <adhemerval.zanella@linaro.org>
Subject: Re: [PATCH] elf: Replace tst-p_alignmod1-editX with a python script
Date: Wed, 26 Jan 2022 11:09:20 +0100 [thread overview]
Message-ID: <877damvmen.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20220125170523.952874-1-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Tue, 25 Jan 2022 14:05:23 -0300")
* Adhemerval Zanella via Libc-alpha:
> diff --git a/scripts/tst-elf-edit.py b/scripts/tst-elf-edit.py
> new file mode 100644
> index 0000000000..1fb9b8e0fe
> --- /dev/null
> +++ b/scripts/tst-elf-edit.py
> @@ -0,0 +1,206 @@
> +class Elf_Ehdr:
> + def __init__(self, e_ident):
> + endian, addr, off = elf_types_fmts(e_ident)
> + self.fmt = '{0}HHI{1}{2}{2}IHHHHHH'.format(endian, addr, off)
> + self.len = struct.calcsize(self.fmt)
> +
> + def read(self, f):
> + buf = f.read(self.len)
> + if not buf:
> + error('{}: header too small'.format(f.name))
I think you need to check len(buf) < self.len.
> +class Elf_Phdr:
> + def __init__(self, e_ident):
> + endian, addr, off = elf_types_fmts(e_ident)
> + self.ei_class = e_ident[EI_CLASS]
> + if self.ei_class == ELFCLASS32:
> + self.fmt = '{0}I{2}{1}{1}IIII'.format(endian, addr, off)
> + else:
> + self.fmt = '{0}II{2}{1}{1}QQQ'.format(endian, addr, off)
> + self.len = struct.calcsize(self.fmt)
> +
> + def read(self, f):
> + buf = f.read(self.len)
> + if not buf:
> + error('{}: program header too small'.format(f.name))
Here as well.
Rest looks okay.
Thanks,
Florian
next prev parent reply other threads:[~2022-01-26 10:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 17:05 Adhemerval Zanella
2022-01-26 10:09 ` Florian Weimer [this message]
2022-01-26 12:10 ` Adhemerval Zanella
2022-01-26 15:35 ` H.J. Lu
2022-01-26 15:45 ` Adhemerval Zanella
2022-01-26 15:46 ` H.J. Lu
2022-01-26 15:54 ` Adhemerval Zanella
2022-01-26 16:11 ` H.J. Lu
2022-01-26 17:11 ` Adhemerval Zanella
2022-01-26 21:43 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877damvmen.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=carlos@redhat.com \
--cc=hjl.tools@gmail.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).