public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches@gcc.gnu.org,  libc-alpha@sourceware.org
Subject: Re: [PATCH] libgomp: Include <limits.h> early to avoid link failure with glibc 2.34
Date: Mon, 12 Jul 2021 16:35:46 +0200	[thread overview]
Message-ID: <877dhva9bx.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <87sg0jabsp.fsf@oldenburg.str.redhat.com> (Florian Weimer's message of "Mon, 12 Jul 2021 15:42:30 +0200")

* Florian Weimer:

> I tested this on csky-linux-gnuabiv2 with the glibc version that failed
> before, and it works.  So I guess your version is fine, too.

Build on powerpc64-linux-gnu and other targets now fails with:

/home/bmg/src/gcc/libgomp/config/linux/affinity.c: In function ‘gomp_init_affini
ty’:
/home/bmg/src/gcc/libgomp/config/linux/affinity.c:53:41: error: ‘ULONG_MAX’ unde
clared (first use in this function)
   53 |       if (!gomp_affinity_init_level (1, ULONG_MAX, true))
      |                                         ^~~~~~~~~

So affinity.c will need to include <limits.h>.

Thanks,
Florian


  reply	other threads:[~2021-07-12 14:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-12  8:26 Florian Weimer
2021-07-12 13:11 ` Florian Weimer
2021-07-12 13:25 ` Jakub Jelinek
2021-07-12 13:42   ` Florian Weimer
2021-07-12 14:35     ` Florian Weimer [this message]
2021-07-12 15:29       ` Florian Weimer
2021-07-13  7:54         ` Jakub Jelinek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877dhva9bx.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).