From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 241293857C7E for ; Mon, 12 Jul 2021 14:35:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 241293857C7E Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-589-12GdlyCDPJyvQwI3PogYXw-1; Mon, 12 Jul 2021 10:35:50 -0400 X-MC-Unique: 12GdlyCDPJyvQwI3PogYXw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 795221882FA5; Mon, 12 Jul 2021 14:35:49 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-103.rdu2.redhat.com [10.10.112.103]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ABF425D9CA; Mon, 12 Jul 2021 14:35:48 +0000 (UTC) From: Florian Weimer To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org, libc-alpha@sourceware.org Subject: Re: [PATCH] libgomp: Include early to avoid link failure with glibc 2.34 References: <87bl78djjs.fsf@oldenburg.str.redhat.com> <20210712132543.GG2380545@tucnak> <87sg0jabsp.fsf@oldenburg.str.redhat.com> Date: Mon, 12 Jul 2021 16:35:46 +0200 In-Reply-To: <87sg0jabsp.fsf@oldenburg.str.redhat.com> (Florian Weimer's message of "Mon, 12 Jul 2021 15:42:30 +0200") Message-ID: <877dhva9bx.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_NUMSUBJECT, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Jul 2021 14:35:53 -0000 * Florian Weimer: > I tested this on csky-linux-gnuabiv2 with the glibc version that failed > before, and it works. So I guess your version is fine, too. Build on powerpc64-linux-gnu and other targets now fails with: /home/bmg/src/gcc/libgomp/config/linux/affinity.c: In function =E2=80=98gom= p_init_affini ty=E2=80=99: /home/bmg/src/gcc/libgomp/config/linux/affinity.c:53:41: error: =E2=80=98UL= ONG_MAX=E2=80=99 unde clared (first use in this function) 53 | if (!gomp_affinity_init_level (1, ULONG_MAX, true)) | ^~~~~~~~~ So affinity.c will need to include . Thanks, Florian