From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 348FE386197D for ; Mon, 28 Jun 2021 12:22:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 348FE386197D Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-533-52zHB9pLPCO12pVuhnJoAQ-1; Mon, 28 Jun 2021 08:22:18 -0400 X-MC-Unique: 52zHB9pLPCO12pVuhnJoAQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 211F21084F78; Mon, 28 Jun 2021 12:22:17 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-228.ams2.redhat.com [10.36.112.228]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 032E527C22; Mon, 28 Jun 2021 12:22:06 +0000 (UTC) From: Florian Weimer To: Andreas Schwab Cc: Florian Weimer via Libc-alpha , Siddhesh Poyarekar , "Mark J. Wielaard" Subject: Re: [PATCH] nptl: Add glibc.pthread.stack_cache_size References: <874kdiusbi.fsf@oldenburg.str.redhat.com> <877die89nl.fsf@igel.home> Date: Mon, 28 Jun 2021 14:22:04 +0200 In-Reply-To: <877die89nl.fsf@igel.home> (Andreas Schwab's message of "Mon, 28 Jun 2021 14:18:38 +0200") Message-ID: <877dietc0j.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jun 2021 12:22:21 -0000 * Andreas Schwab: > On Jun 28 2021, Florian Weimer via Libc-alpha wrote: > >> diff --git a/nptl/nptl-stack.h b/nptl/nptl-stack.h >> index a6bd8df77f..19d040431e 100644 >> --- a/nptl/nptl-stack.h >> +++ b/nptl/nptl-stack.h >> @@ -25,6 +25,9 @@ >> #include >> #include >> >> +/* Maximum size in kB of cache. 40MiBi by default. */ >> +extern size_t __nptl_stack_cache_maxsize attribute_hidden; > > Kilobytes or bytes? Oh, looks like the original comment was wrong. stackblock_size, among other things, is measured in bytes. I have changed it locally to: /* Maximum size of the cache, in bytes. 40 MiB by default. */ Thanks, Florian