From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id AF29B3857C7F for ; Sun, 7 Feb 2021 09:45:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AF29B3857C7F Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-298-JE4noS5vOMC807vRJQoXrg-1; Sun, 07 Feb 2021 04:44:58 -0500 X-MC-Unique: JE4noS5vOMC807vRJQoXrg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 98C45803F47; Sun, 7 Feb 2021 09:44:57 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-116.ams2.redhat.com [10.36.112.116]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BB45057; Sun, 7 Feb 2021 09:44:56 +0000 (UTC) From: Florian Weimer To: Max Gautier via Libc-alpha Cc: Max Gautier Subject: Re: [PATCH v3 4/5] Make terminating base64 sequences mandatory References: <87y2m9agmm.fsf@mid.deneb.enyo.de> <20210125090226.39967-1-mg@max.gautier.name> <20210125090226.39967-5-mg@max.gautier.name> Date: Sun, 07 Feb 2021 10:45:07 +0100 In-Reply-To: <20210125090226.39967-5-mg@max.gautier.name> (Max Gautier via Libc-alpha's message of "Mon, 25 Jan 2021 10:02:25 +0100") Message-ID: <877dnk9pp8.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Feb 2021 09:45:01 -0000 * Max Gautier via Libc-alpha: > In the modified UTF-7 encoding, unlike in UTF-7, one MUST terminate all > base64 sequence with the '-' character. > MODIFIED-UTF-7 -> INTERNAL : make unterminated sequences illegal > INTERNAL -> MODIFIED-UTF-7 : always terminate the sequences Still mentions MODIFIED-UTF-7. This should be folded into the main patch (conditional for UTF-7-IMAP). The explanation in the commit message should be put into a source code comment. Thanks, Florian -- Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243, Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill