From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 440393851C13 for ; Wed, 23 Dec 2020 14:27:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 440393851C13 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-149-52RHXwsxOaGrjU_nRK6DPg-1; Wed, 23 Dec 2020 09:27:29 -0500 X-MC-Unique: 52RHXwsxOaGrjU_nRK6DPg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BF6379CC0D; Wed, 23 Dec 2020 14:27:28 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-112-120.ams2.redhat.com [10.36.112.120]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1285C60BE5; Wed, 23 Dec 2020 14:27:27 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH v2 4/4] posix: Add posix_spawn_file_actions_closefrom References: <20201222212754.387111-1-adhemerval.zanella@linaro.org> <20201222212754.387111-4-adhemerval.zanella@linaro.org> Date: Wed, 23 Dec 2020 15:27:26 +0100 In-Reply-To: <20201222212754.387111-4-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Tue, 22 Dec 2020 18:27:54 -0300") Message-ID: <877dp8r41d.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Dec 2020 14:27:34 -0000 * Adhemerval Zanella: > +* The posix_spawn_file_actions_closefrom_np has been added, enabling > + posix_spawn and posix_spawnp to close all file descriptors greater tha= n > + a giver integer. This function is a GNU extension, although Solaris a= lso > + provides a similar function. =E2=80=9CThe function posix_spawn_file_actions_closefrom_np=E2=80=9D? > +static void > +do_test_closefrom (void) > +{ > + int lowfd =3D xopen ("/dev/null", O_WRONLY, 0); > + for (int i =3D 1; i < NFDS; i++) > + xopen ("/dev/null", O_WRONLY, 0); The usual observation about NFDS and fgap checking. > + /* Create some gaps, close up to a threshold, and check result. */ > + xclose (57); > + xclose (78); > + xclose (81); > + xclose (82); > + xclose (84); > + xclose (90); Please add lowfd here as well. > diff --git a/sysdeps/unix/sysv/linux/spawni.c b/sysdeps/unix/sysv/linux/s= pawni.c > index f157bfffd2..c337c7a6a1 100644 > --- a/sysdeps/unix/sysv/linux/spawni.c > +++ b/sysdeps/unix/sysv/linux/spawni.c > @@ -16,22 +16,17 @@ > License along with the GNU C Library; if not, see > . */ > =20 > -#include > -#include > -#include > -#include > -#include > -#include > -#include > -#include > -#include > +#include > +#include > +#include > #include > +#include > +#include > #include > -#include > -#include > -#include > -#include > -#include "spawn_int.h" > +#include > +#include > +#include > +#include Is really required here? Thanks, Florian --=20 Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243, Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'N= eill