From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fw@deneb.enyo.de>
Received: from albireo.enyo.de (albireo.enyo.de [37.24.231.21])
 by sourceware.org (Postfix) with ESMTPS id BC3CB386F41D
 for <libc-alpha@sourceware.org>; Tue, 17 Nov 2020 17:51:18 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BC3CB386F41D
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=deneb.enyo.de
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=fw@deneb.enyo.de
Received: from [172.17.203.2] (helo=deneb.enyo.de)
 by albireo.enyo.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 id 1kf58P-0005oB-6X; Tue, 17 Nov 2020 17:51:17 +0000
Received: from fw by deneb.enyo.de with local (Exim 4.92)
 (envelope-from <fw@deneb.enyo.de>)
 id 1kf58P-0000xU-3c; Tue, 17 Nov 2020 18:51:17 +0100
From: Florian Weimer <fw@deneb.enyo.de>
To: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Cc: Andreas Schwab <schwab@linux-m68k.org>,
 Adhemerval Zanella <adhemerval.zanella@linaro.org>
Subject: Re: [PATCH] linux: mips: Fix getdents64 fallback on mips64-n32
References: <20201116211743.2228063-1-adhemerval.zanella@linaro.org>
 <873619gfo2.fsf@mid.deneb.enyo.de>
 <08cc387e-e0ec-7242-fdc6-a9b163331986@linaro.org>
 <87y2j0yugc.fsf@igel.home>
 <2b8cb2fc-b4c7-617a-39f4-de0b11f3ecc6@linaro.org>
Date: Tue, 17 Nov 2020 18:51:17 +0100
In-Reply-To: <2b8cb2fc-b4c7-617a-39f4-de0b11f3ecc6@linaro.org> (Adhemerval
 Zanella via Libc-alpha's message of "Tue, 17 Nov 2020 14:37:21 -0300")
Message-ID: <877dqj6fe2.fsf@mid.deneb.enyo.de>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 KAM_NUMSUBJECT, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Nov 2020 17:51:19 -0000

* Adhemerval Zanella via Libc-alpha:

> Not that good, I see a large stack usage (1456 vs 1152 from my initial
> version) and some more memory load/store memory instructions.  The
> kdp type change does not change the code generation.

That's why I suggested to use two separately defined struct types for
this.