public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Alistair Francis via Libc-alpha <libc-alpha@sourceware.org>
Cc: Alistair Francis <alistair.francis@wdc.com>
Subject: Re: [PATCH v2] linux: wait4: Fix incorrect return value comparison
Date: Tue, 07 Apr 2020 13:23:18 +0200	[thread overview]
Message-ID: <877dyr8rq1.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <20200407054010.2573333-1-alistair.francis@wdc.com> (Alistair Francis via Libc-alpha's message of "Mon, 6 Apr 2020 22:40:10 -0700")

* Alistair Francis via Libc-alpha:

> Path 600f00b "linux: Use long time_t for wait4/getrusage" introduced

Typo: "Path"

> two bugs:
>  - The usage32 struct was set if the wait4 syscall had an error.
>  - For 32-bit systems the usage struct was set even if it was specified
>    as NULL.
>
> This patch fixes the two issues.

Would it make sense to include a test case?

(Somehow, my earlier message did not make it it to the list.)

Thanks,
Florian


  parent reply	other threads:[~2020-04-07 11:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-07  5:40 Alistair Francis
2020-04-07  7:35 ` Andreas Schwab
2020-04-07 11:23 ` Florian Weimer [this message]
2020-04-07 13:24   ` Adhemerval Zanella
2020-04-07 14:47     ` Alistair Francis
2020-04-09 15:35       ` Florian Weimer
2020-04-09 15:41         ` Adhemerval Zanella
2020-04-09 20:13         ` Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877dyr8rq1.fsf@oldenburg2.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=alistair.francis@wdc.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).