* [PATCH] <dirent.h>: Remove wrong comment about getdents64() declaration
@ 2019-10-07 13:07 Petr Vorel
2019-10-07 13:12 ` Florian Weimer
0 siblings, 1 reply; 6+ messages in thread
From: Petr Vorel @ 2019-10-07 13:07 UTC (permalink / raw)
To: libc-alpha; +Cc: Petr Vorel, Florian Weimer
Originally the public interface for getdents64 was declared in
<unistd.h> in 51ea67d548. Later, b8b3d5a14e moved it to <dirent.h>.
Fixes: b8b3d5a14e ("Linux: Move getdents64 to <dirent.h>")
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
include/dirent.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/dirent.h b/include/dirent.h
index 3736803bce..1f0121f3d9 100644
--- a/include/dirent.h
+++ b/include/dirent.h
@@ -36,8 +36,7 @@ extern __ssize_t __getdirentries (int __fd, char *__restrict __buf,
__off_t *__restrict __basep)
__THROW __nonnull ((2, 4));
-/* These functions are only implemented on Linux. The public
- interface for getdents64 is declared in <unistd.h>. */
+/* These functions are only implemented on Linux. */
extern __ssize_t __getdents (int __fd, void *__buf, size_t __nbytes)
attribute_hidden;
extern __ssize_t __getdents64 (int __fd, void *__buf, size_t __nbytes);
--
2.23.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] <dirent.h>: Remove wrong comment about getdents64() declaration
2019-10-07 13:07 [PATCH] <dirent.h>: Remove wrong comment about getdents64() declaration Petr Vorel
@ 2019-10-07 13:12 ` Florian Weimer
2019-10-07 13:16 ` Petr Vorel
0 siblings, 1 reply; 6+ messages in thread
From: Florian Weimer @ 2019-10-07 13:12 UTC (permalink / raw)
To: Petr Vorel; +Cc: libc-alpha
* Petr Vorel:
> Originally the public interface for getdents64 was declared in
> <unistd.h> in 51ea67d548. Later, b8b3d5a14e moved it to <dirent.h>.
>
> Fixes: b8b3d5a14e ("Linux: Move getdents64 to <dirent.h>")
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> include/dirent.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/dirent.h b/include/dirent.h
> index 3736803bce..1f0121f3d9 100644
> --- a/include/dirent.h
> +++ b/include/dirent.h
> @@ -36,8 +36,7 @@ extern __ssize_t __getdirentries (int __fd, char *__restrict __buf,
> __off_t *__restrict __basep)
> __THROW __nonnull ((2, 4));
>
> -/* These functions are only implemented on Linux. The public
> - interface for getdents64 is declared in <unistd.h>. */
> +/* These functions are only implemented on Linux. */
> extern __ssize_t __getdents (int __fd, void *__buf, size_t __nbytes)
> attribute_hidden;
> extern __ssize_t __getdents64 (int __fd, void *__buf, size_t __nbytes);
Looks good to me, thanks. I assume you don't have commit access. I can
install the patch for you.
Florian
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] <dirent.h>: Remove wrong comment about getdents64() declaration
2019-10-07 13:12 ` Florian Weimer
@ 2019-10-07 13:16 ` Petr Vorel
2019-10-09 9:32 ` Florian Weimer
0 siblings, 1 reply; 6+ messages in thread
From: Petr Vorel @ 2019-10-07 13:16 UTC (permalink / raw)
To: Florian Weimer; +Cc: libc-alpha
Hi Florian,
...
> > -/* These functions are only implemented on Linux. The public
> > - interface for getdents64 is declared in <unistd.h>. */
> > +/* These functions are only implemented on Linux. */
> > extern __ssize_t __getdents (int __fd, void *__buf, size_t __nbytes)
> > attribute_hidden;
> > extern __ssize_t __getdents64 (int __fd, void *__buf, size_t __nbytes);
> Looks good to me, thanks. I assume you don't have commit access. I can
> install the patch for you.
Thanks for review. No, I don't have commit access :).
> Florian
Kind regards,
Petr
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] <dirent.h>: Remove wrong comment about getdents64() declaration
2019-10-07 13:16 ` Petr Vorel
@ 2019-10-09 9:32 ` Florian Weimer
2019-10-09 12:19 ` Petr Vorel
0 siblings, 1 reply; 6+ messages in thread
From: Florian Weimer @ 2019-10-09 9:32 UTC (permalink / raw)
To: Petr Vorel; +Cc: libc-alpha
* Petr Vorel:
> Hi Florian,
>
> ...
>> > -/* These functions are only implemented on Linux. The public
>> > - interface for getdents64 is declared in <unistd.h>. */
>> > +/* These functions are only implemented on Linux. */
>> > extern __ssize_t __getdents (int __fd, void *__buf, size_t __nbytes)
>> > attribute_hidden;
>> > extern __ssize_t __getdents64 (int __fd, void *__buf, size_t __nbytes);
>
>> Looks good to me, thanks. I assume you don't have commit access. I can
>> install the patch for you.
> Thanks for review. No, I don't have commit access :).
Thanks, I've messaged the patch a little bit and pushed it for yoy.
Florian
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] <dirent.h>: Remove wrong comment about getdents64() declaration
2019-10-09 9:32 ` Florian Weimer
@ 2019-10-09 12:19 ` Petr Vorel
2019-10-09 12:22 ` Florian Weimer
0 siblings, 1 reply; 6+ messages in thread
From: Petr Vorel @ 2019-10-09 12:19 UTC (permalink / raw)
To: Florian Weimer; +Cc: libc-alpha
Hi Florian,
> > ...
> >> > -/* These functions are only implemented on Linux. The public
> >> > - interface for getdents64 is declared in <unistd.h>. */
> >> > +/* These functions are only implemented on Linux. */
> >> > extern __ssize_t __getdents (int __fd, void *__buf, size_t __nbytes)
> >> > attribute_hidden;
> >> > extern __ssize_t __getdents64 (int __fd, void *__buf, size_t __nbytes);
> >> Looks good to me, thanks. I assume you don't have commit access. I can
> >> install the patch for you.
> > Thanks for review. No, I don't have commit access :).
> Thanks, I've messaged the patch a little bit and pushed it for yoy.
Thanks a lot!
BTW I've noticed discussion on ML about dropping ChangeLogs,
but I guess it'll be dropped after 2.31 release.
> Florian
Kind regards,
Petr
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] <dirent.h>: Remove wrong comment about getdents64() declaration
2019-10-09 12:19 ` Petr Vorel
@ 2019-10-09 12:22 ` Florian Weimer
0 siblings, 0 replies; 6+ messages in thread
From: Florian Weimer @ 2019-10-09 12:22 UTC (permalink / raw)
To: Petr Vorel; +Cc: libc-alpha
* Petr Vorel:
> BTW I've noticed discussion on ML about dropping ChangeLogs,
> but I guess it'll be dropped after 2.31 release.
I'm not sure about that yet. But it was easy to add the ChangeLog entry
so that I could push the fix now.
Thanks,
Florian
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-10-09 12:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-07 13:07 [PATCH] <dirent.h>: Remove wrong comment about getdents64() declaration Petr Vorel
2019-10-07 13:12 ` Florian Weimer
2019-10-07 13:16 ` Petr Vorel
2019-10-09 9:32 ` Florian Weimer
2019-10-09 12:19 ` Petr Vorel
2019-10-09 12:22 ` Florian Weimer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).