From: Florian Weimer <fw@deneb.enyo.de>
To: Lukasz Majewski <lukma@denx.de>
Cc: Joseph Myers <joseph@codesourcery.com>,
Alistair Francis <alistair23@gmail.com>,
Alistair Francis <alistair.francis@wdc.com>,
Zack Weinberg <zackw@panix.com>, Arnd Bergmann <arnd@arndb.de>,
GNU C Library <libc-alpha@sourceware.org>,
Adhemerval Zanella <adhemerval.zanella@linaro.org>,
Florian Weimer <fweimer@redhat.com>,
Carlos O'Donell <carlos@redhat.com>,
Stepan Golosunov <stepan@golosunov.pp.ru>
Subject: Re: [PATCH v8 1/3] y2038: Introduce internal for glibc struct __timespec64
Date: Wed, 25 Sep 2019 12:51:00 -0000 [thread overview]
Message-ID: <877e5wtu7y.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <20190925094540.14be491d@jawa> (Lukasz Majewski's message of "Wed, 25 Sep 2019 09:45:40 +0200")
* Lukasz Majewski:
>> I think it's generally for reviewers to say if their view is "I think
>> this patch is OK but we should allow more time for other people to
>> comment", rather than expecting patch contributors to judge when they
>> need to wait further after a patch approval.
>
> Yes. I do understand.
>
> If I may ask - what is the "acceptable" time for other people from
> community to jump in and comment the patch before it shall be
> applied?
>
> Is it one week or more/less ?
A week is more than enough, especially for patches that only touch
internals like this one.
Regarding the actual patch, I don't understand why tv_pad isn't an
*anonymous* bit field. This seems to introduce unnecessary variance
between architectures and is incompatible with how glibc itself uses
struct timespec. It's also inconsistent with the new comment in
include/time.h (named padding is only needed if you need to
zero-initialize the padding).
next prev parent reply other threads:[~2019-09-25 12:51 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 21:16 [PATCH v8 0/3] y2038: Linux: Introduce __clock_settime64 function Lukasz Majewski
2019-09-18 21:16 ` [PATCH v8 2/3] y2038: Provide conversion helpers for struct __timespec64 Lukasz Majewski
2019-09-19 20:17 ` Joseph Myers
2019-09-19 21:21 ` Lukasz Majewski
2019-09-19 21:29 ` Joseph Myers
2019-09-19 22:03 ` Lukasz Majewski
2019-09-19 22:17 ` Joseph Myers
2019-09-19 22:22 ` Lukasz Majewski
2019-09-18 21:16 ` [PATCH v8 1/3] y2038: Introduce internal for glibc " Lukasz Majewski
2019-09-19 20:14 ` Joseph Myers
2019-09-23 21:22 ` Lukasz Majewski
2019-09-25 0:47 ` Joseph Myers
2019-09-25 7:45 ` Lukasz Majewski
2019-09-25 12:51 ` Florian Weimer [this message]
2019-09-25 13:34 ` Lukasz Majewski
2019-09-25 13:40 ` Florian Weimer
2019-09-25 14:38 ` Lukasz Majewski
2019-09-25 16:29 ` Joseph Myers
2019-09-25 20:03 ` Lukasz Majewski
2019-09-25 12:43 ` Florian Weimer
2019-09-25 13:06 ` Lukasz Majewski
2019-09-25 13:07 ` Florian Weimer
2019-09-18 21:16 ` [PATCH v8 3/3] y2038: linux: Provide __clock_settime64 implementation Lukasz Majewski
2019-09-18 21:43 ` Joseph Myers
2019-09-18 22:34 ` Lukasz Majewski
2019-09-19 22:01 ` Lukasz Majewski
2019-09-18 23:37 ` [PATCH v8 0/3] y2038: Linux: Introduce __clock_settime64 function Alistair Francis
2019-09-19 7:51 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877e5wtu7y.fsf@mid.deneb.enyo.de \
--to=fw@deneb.enyo.de \
--cc=adhemerval.zanella@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=arnd@arndb.de \
--cc=carlos@redhat.com \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=lukma@denx.de \
--cc=stepan@golosunov.pp.ru \
--cc=zackw@panix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).