From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 811103858D20 for ; Tue, 11 Apr 2023 12:21:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 811103858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn Received: from loongson.cn (unknown [10.20.4.187]) by gateway (Coremail) with SMTP id _____8Bxfdq6UDVkDigaAA--.29076S3; Tue, 11 Apr 2023 20:21:14 +0800 (CST) Received: from [10.20.4.187] (unknown [10.20.4.187]) by localhost.localdomain (Coremail) with SMTP id AQAAf8Dxxry5UDVkLWEeAA--.30434S3; Tue, 11 Apr 2023 20:21:13 +0800 (CST) Subject: Re: [PATCH v5 22/22] loongarch: Fix Race conditions in pthread cancellation [BZ#12683] From: caiyinyu To: Xi Ruoyao , Adhemerval Zanella , libc-alpha@sourceware.org References: <20230410195907.4123869-1-adhemerval.zanella@linaro.org> <20230410204614.4129551-1-adhemerval.zanella@linaro.org> <20230410204614.4129551-14-adhemerval.zanella@linaro.org> <2618ef1ef31911d4d9ab8e4945878595f2df2a07.camel@xry111.site> <85036382-d75c-87ce-5a5c-f016d976d0cd@loongson.cn> Message-ID: <8782c48e-5ac1-6f51-9023-52d3f7a0628e@loongson.cn> Date: Tue, 11 Apr 2023 20:21:13 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <85036382-d75c-87ce-5a5c-f016d976d0cd@loongson.cn> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID:AQAAf8Dxxry5UDVkLWEeAA--.30434S3 X-CM-SenderInfo: 5fdl5xhq1xqz5rrqw2lrqou0/ X-Coremail-Antispam: 1Uk129KBjvdXoWrKrWfGryfXrWfGw15AF4ruFg_yoWfCFb_AF 47CFyUur15C3y8Kr1v9ryruasxAry0qF1UGws0krZ5XF4xtF95A3s5G3s5ArnrGw48Jry5 Ar4DXr43Ary7ujkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8wcxFpf9Il3svdxBIdaVrn0 xqx4xG64xvF2IEw4CE5I8CrVC2j2Jv73VFW2AGmfu7bjvjm3AaLaJ3UjIYCTnIWjp_UUUY g7kC6x804xWl14x267AKxVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0rVWrJVCq3w AFIxvE14AKwVWUGVWUXwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK 6xIIjxv20xvE14v26r1j6r1xM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r1j6r4UM28EF7 xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I0E14v26rxl6s0DM2AIxVAI cxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx1l5I8CrVACY4xI64kE6c 02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE 4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0VAS07AlzVAYIcxG8wCF04k20x vY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwCFI7km07C267AKxVWUXVWUAwC20s02 6c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jr v_JF1lIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvE c7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14 v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7I U8czVUUUUUU== X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,BODY_8BITS,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: 在 2023/4/11 下午8:00, caiyinyu 写道: > > 在 2023/4/11 下午2:19, Xi Ruoyao 写道: >> On Mon, 2023-04-10 at 17:46 -0300, Adhemerval Zanella via Libc-alpha >> wrote: >> >> /* snip */ >> >>> +1: >>> +       addi.d  $r3,$r3,-16 >>> +       cfi_def_cfa_offset (16) >>> +       st.d    $r1,$r3,8 >>> +       cfi_offset (1, -8) >>> +       bl      __syscall_do_cancel >> Can we simply use "b __syscall_do_cancel" for 1: like AArch64? > > In LoongArch, the "b" instruction is equivalent to the "b" instruction > in AArch64, and similarly, > > the "bl" instruction in LoongArch is equivalent to the "bl" > instruction in AArch64. This is our instruction manual. https://loongson.github.io/LoongArch-Documentation/LoongArch-Vol1-EN.html#arithmetic-operation-instructions > >>> + >>> +END (__syscall_cancel_arch)