From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 8E3003858D3C for ; Mon, 17 Jan 2022 14:30:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8E3003858D3C Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-614-fjLswXvLMC2Jo0s9Qu_rsw-1; Mon, 17 Jan 2022 09:30:28 -0500 X-MC-Unique: fjLswXvLMC2Jo0s9Qu_rsw-1 Received: by mail-qk1-f200.google.com with SMTP id q5-20020a05620a0d8500b004738c1b48beso13474189qkl.7 for ; Mon, 17 Jan 2022 06:30:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=0RM0X5F4yyxcNoP+tZr7JwY4m2A8q0Zgsyr1ELGGx1E=; b=BH+unnNfJlTXrOPRE9KfDT6PMNbpo7MQXWwgJAa8d3KZaI++qI9s4JNYwZTRPttAb1 ICFHJgOCdMrFE9Sjgzf1GVAAJSKivEel1W//qN7HmoJ3yrLcQ72V2/gUtqEl3UENldGs fcmN/AzSilZRrKMPjKEkUIlD1Lf75LXo3PNYi3PLf3aG7tLc9g86q9ro1mbQONUQDHc4 tbqIZ6DWDjKRnBQaw9sLVAo/Hwwr/WzkKempiL9/Puq1cvGCYow/+CJkqxRxs5BIakLA 3oGzxra8rdYLJzF894REtPXJ7aBmfqabPgdKeEZSbIk92h/x6CssIHHl/KXfaLc0qrVQ BI2A== X-Gm-Message-State: AOAM531EBC+0Xdf6qBKifdYGRLdJpaL9YawiireaTJ1mHGTkEvaIjwVC 9P45ZcEtwT3CUXcpVNpp6ug3YO8UX+NNBgcwcvTfwEhfyiRPicosMpooajymVeiBtF9gPullSnN 3RAOj4FCteUVn8BxGz3ji X-Received: by 2002:ac8:58c3:: with SMTP id u3mr10514589qta.546.1642429827658; Mon, 17 Jan 2022 06:30:27 -0800 (PST) X-Google-Smtp-Source: ABdhPJwO88kkeMGUDXhkFIBJ8LqQgDDBKMyFeKPuO5yM34FHrjFAk/xtC26yLnCNa8hsKAL/+kwpaw== X-Received: by 2002:ac8:58c3:: with SMTP id u3mr10514577qta.546.1642429827469; Mon, 17 Jan 2022 06:30:27 -0800 (PST) Received: from [192.168.0.241] (135-23-175-80.cpe.pppoe.ca. [135.23.175.80]) by smtp.gmail.com with ESMTPSA id w9sm9323727qko.71.2022.01.17.06.30.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Jan 2022 06:30:26 -0800 (PST) Message-ID: <8789d1f2-e97e-1b8b-3a1a-23f6cca1b991@redhat.com> Date: Mon, 17 Jan 2022 09:30:23 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH] Linux: Add epoll_pwait2 To: Florian Weimer , Adhemerval Zanella via Libc-alpha Cc: alx.manpages@gmail.com, Adhemerval Zanella References: <20220112193702.2901382-1-adhemerval.zanella@linaro.org> <87wnj4j6dx.fsf@oldenburg.str.redhat.com> From: Carlos O'Donell Organization: Red Hat In-Reply-To: <87wnj4j6dx.fsf@oldenburg.str.redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_NUMSUBJECT, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Jan 2022 14:30:30 -0000 On 1/13/22 05:07, Florian Weimer wrote: > * Adhemerval Zanella via Libc-alpha: > >> It is similar to epoll_wait, with the difference the timeout has >> nanosecond resoluting by using struct timespec instead of int. >> >> Although Linux interface only provides 64 bit time_t support, old >> 32 bit interface is also provided (so keep in sync with current >> practice and to no force opt-in on 64 bit time_t). >> >> Checked on x86_64-linux-gnu and i686-linux-gnu. > > Patch looks okay to me, but this probably needs RM approval. > > Reviewed-by: Florian Weimer > > Carlos? Approved for glibc 2.35. Syscall wrappers are very narrow ABI additions and enabling new syscalls is important enough. -- Cheers, Carlos.