From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Stefan Liebler <stli@linux.ibm.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH] string: Add hidden builtin definition for __strcpy_chk.
Date: Mon, 5 Feb 2024 15:12:46 -0300 [thread overview]
Message-ID: <878ccbd7-55a8-4129-af0b-2a5d25544f15@linaro.org> (raw)
In-Reply-To: <20240205132206.1603576-1-stli@linux.ibm.com>
On 05/02/24 10:22, Stefan Liebler wrote:
> Otherwise on at least x86_64 and s390x there is an unwanted PLT entry
> in libc.so when configured with --enable-fortify-source and build
> with -Os.
I think it would be useful to add that it also requires --enable-fortify-source=3
to trigger it.
>
> This is observed in elf/check-localplt
> Extra PLT reference: libc.so: __strcpy_chk
>
> The call to PLT entry is in inet/ruserpass.c.
LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> ---
> debug/strcpy_chk.c | 1 +
> include/string.h | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/debug/strcpy_chk.c b/debug/strcpy_chk.c
> index e54780ddde..dd2c453417 100644
> --- a/debug/strcpy_chk.c
> +++ b/debug/strcpy_chk.c
> @@ -31,3 +31,4 @@ __strcpy_chk (char *dest, const char *src, size_t destlen)
>
> return memcpy (dest, src, len + 1);
> }
> +libc_hidden_builtin_def (__strcpy_chk)
> diff --git a/include/string.h b/include/string.h
> index 86d1fa4abe..3b4c6007d7 100644
> --- a/include/string.h
> +++ b/include/string.h
> @@ -215,6 +215,7 @@ libc_hidden_builtin_proto (__mempcpy_chk)
> libc_hidden_builtin_proto (__memset_chk)
> libc_hidden_builtin_proto (__stpcpy_chk)
> libc_hidden_builtin_proto (__strncpy_chk)
> +libc_hidden_builtin_proto (__strcpy_chk)
>
> #endif
>
next prev parent reply other threads:[~2024-02-05 18:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 13:22 Stefan Liebler
2024-02-05 18:12 ` Adhemerval Zanella Netto [this message]
2024-02-06 8:19 ` Stefan Liebler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878ccbd7-55a8-4129-af0b-2a5d25544f15@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
--cc=stli@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).