public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Andreas Schwab <schwab@suse.de>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] stdlib: fix grouping verification with multi-byte thousands separator
Date: Thu, 12 Oct 2023 11:33:14 +0200	[thread overview]
Message-ID: <878r88kwx1.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <mvm4jiwxk8g.fsf@suse.de> (Andreas Schwab's message of "Thu, 12 Oct 2023 11:28:47 +0200")

* Andreas Schwab:

> On Okt 12 2023, Florian Weimer wrote:
>
>> * Andreas Schwab:
>>
>>> @@ -91,7 +84,7 @@ __correctly_grouped_prefixmb (const STRING_TYPE *begin, const STRING_TYPE *end,
>>>        if (cp < begin)
>>>  	return end;
>>>  
>>> -      if (end - cp == (int) *gp + 1)
>>> +      if (end - cp == (int) *gp + thousands_len)
>>>  	{
>>>  	  /* This group matches the specification.  */
>>
>> This still does not work for alternative digits, right?  But that's an
>> existing limitation of strto[dl]?
>
> strtod only supports [0-9].
>
>> Does this need a bug?
>
> Bug 30964.

Thanks, please commit this with the bug reference in the commit message.

Florian


      reply	other threads:[~2023-10-12  9:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-11 14:49 Andreas Schwab
2023-10-12  8:25 ` Florian Weimer
2023-10-12  9:28   ` Andreas Schwab
2023-10-12  9:33     ` Florian Weimer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878r88kwx1.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).