From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id A485A3858D39 for ; Fri, 19 May 2023 12:45:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A485A3858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684500331; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M8imqp4vtVe/YnNH+oFWDoMX1CW2xgSpS6AKea+rHmc=; b=Sp+tSwX+Uoo1TO4bxfJThUqruwQLVDyEiWPycUNQ5gibk96edJkgCtxOMnj3we7eSclWq9 a246atK27cIQhrTTuISahAsNDSMGFwfKoheoCasVrxZGhQwFwd82qPyvrNB/lPw7vgGBqf jPMbpioZO6xOw+fSSi7NrKVa4EDTU7Q= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-630-Qe8eitmTOTm36zI1-pkaNg-1; Fri, 19 May 2023 08:45:30 -0400 X-MC-Unique: Qe8eitmTOTm36zI1-pkaNg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8DE6A1C02D2C; Fri, 19 May 2023 12:45:29 +0000 (UTC) Received: from oldenburg3.str.redhat.com (unknown [10.39.192.229]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B861040D1B60; Fri, 19 May 2023 12:45:28 +0000 (UTC) From: Florian Weimer To: Alejandro Colomar Cc: Carlos O'Donell , libc-alpha@sourceware.org, Noah Goldstein , Adhemerval Zanella Subject: Re: [PATCH 1/1] Add lint-makefiles Makefile linting test. References: <20230519121354.704395-1-carlos@redhat.com> <20230519121354.704395-2-carlos@redhat.com> Date: Fri, 19 May 2023 14:45:27 +0200 In-Reply-To: (Alejandro Colomar's message of "Fri, 19 May 2023 14:35:56 +0200") Message-ID: <878rdkjxqw.fsf@oldenburg3.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Alejandro Colomar: > Hi Carlos, > > On 5/19/23 14:13, Carlos O'Donell via Libc-alpha wrote: >> We add a `make check` test that lints all Makefiles in the source >> directory of the glibc build. This linting test ensures that the >> lines in all Makefiles will be sorted correctly as developers >> creates patches. > > make check is usually to test the result of a build, according the > GNU guidelines in: > > > > I believe linting the source code is a different thing, and so I > used a different target in the Linux man-pages Makefile: 'lint'. > > So, in the man-pages project, it goes like this: > > lint -> build -> check -> install > > Maybe you could follow a similar scheme? Otherwise, it's a bit > weird to run the linters _after_ building (since `make check` > requires previously building). I think the consistency with the existing tests is more important. The way Carlos implemented it, it becomes part of developer workflows automatically. Thanks, Florian