From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 539523858D28 for ; Thu, 6 Apr 2023 15:10:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 539523858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680793805; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zlhJRIGS4Tf75UpCr9CzECYBWpm+LF411z9RG8j6Fqc=; b=g62B1QI7bcFmZ1oCnOpVIiVVrOXh1UGZoaD6y3JCJkbaZHhA7zeu0/mhvgOT1uWuOX3sTU 6HW+XWuD+TgREUr+Yl3gbrWRfYdIotGlzVoh2BCfsWooACYHLr2K4AeINJ2jKe0lts6ekw n9CziBhUnqlewuaVxVEUg9DSmLjT5oc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-486-B5qhTDeYMfuAMQclilMmOA-1; Thu, 06 Apr 2023 11:10:01 -0400 X-MC-Unique: B5qhTDeYMfuAMQclilMmOA-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 925A4890F75; Thu, 6 Apr 2023 15:10:01 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.84]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0A8BC492C18; Thu, 6 Apr 2023 15:10:00 +0000 (UTC) From: Florian Weimer To: Siddhesh Poyarekar Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 1/2] Implement strlcpy and strlcat [BZ #178] References: Date: Thu, 06 Apr 2023 17:09:59 +0200 In-Reply-To: (Siddhesh Poyarekar's message of "Thu, 6 Apr 2023 10:22:55 -0400") Message-ID: <878rf5m4hk.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Siddhesh Poyarekar: > On 2023-04-05 07:20, Florian Weimer via Libc-alpha wrote: >> --- a/debug/Makefile >> +++ b/debug/Makefile >> @@ -31,6 +31,7 @@ headers := execinfo.h >> routines = backtrace backtracesyms backtracesymsfd noophooks \ >> memcpy_chk memmove_chk mempcpy_chk memset_chk stpcpy_chk \ >> strcat_chk strcpy_chk strncat_chk strncpy_chk stpncpy_chk \ >> + strlcpy_chk strlcat_chk \ > > Do you want to commit an obvious change first to update this routine > list to be one per line? I supoose I could do that, also for string and wcsmbs. >> diff --git a/manual/string.texi b/manual/string.texi >> index e06433187e..e3979f1d0f 100644 >> --- a/manual/string.texi >> +++ b/manual/string.texi >> @@ -1068,6 +1068,60 @@ processing text. Also, this function has significant performance >> issues. @xref{Concatenating Strings}. >> @end deftypefun >> +@deftypefun size_t strlcpy (char *restrict @var{to}, const char >> *restrict @var{from}, size_t @var{size}) >> +@standards{BSD, string.h} > > Should we also mention POSIX here? It would be misleading because it's not possible to enable this using _POSIX_SOURCE, I think. Thanks, Florian