From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fweimer@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
	by sourceware.org (Postfix) with ESMTPS id 108B33856974
	for <libc-alpha@sourceware.org>; Fri, 21 Oct 2022 18:24:30 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 108B33856974
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1666376669;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=3le1aYM1ZcKYm1if5jmtOvAD1a303z6EGewVAaGJdRA=;
	b=P853oTco35VmbNlBN2nH7MEuiLCO5MCNDl5EWy84wk101S6OEYdCNQG1uo8MOPr+4XiyCI
	YVV9pEGeOoWD3VyBBcDArjLgCsDt9youtC8OSZ/cTjrF3G6e8wbr4ncMvSWz5aaQ08Lbf/
	wSfKorpUkTwhr03NiZMZd2Kf623KpPs=
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-263-Bgxx1LEKNZOO3Naw5skawQ-1; Fri, 21 Oct 2022 14:24:26 -0400
X-MC-Unique: Bgxx1LEKNZOO3Naw5skawQ-1
Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C037C2823816;
	Fri, 21 Oct 2022 18:24:25 +0000 (UTC)
Received: from oldenburg.str.redhat.com (unknown [10.2.16.74])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 4420A49BB67;
	Fri, 21 Oct 2022 18:24:22 +0000 (UTC)
From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] elf: Introduce to _dl_call_fini
References: <87zge0x8fr.fsf@oldenburg.str.redhat.com>
	<865a135b-fb4a-2fa2-b858-105fa0e148ac@linaro.org>
Date: Fri, 21 Oct 2022 20:24:12 +0200
In-Reply-To: <865a135b-fb4a-2fa2-b858-105fa0e148ac@linaro.org> (Adhemerval
	Zanella Netto's message of "Fri, 21 Oct 2022 14:51:20 -0300")
Message-ID: <878rl9827n.fsf@oldenburg.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain
X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libc-alpha.sourceware.org>

* Adhemerval Zanella Netto:

> On 13/10/22 08:35, Florian Weimer via Libc-alpha wrote:
>> This consolidates the destructor invocations from _dl_fini and
>> dlclose.  Remove the micro-optimization that avoids
>> calling _dl_call_fini if they are no destructors (as dlclose is quite
>> expensive anyway).
>> 
>
> LGTM, I think the debug message change should be ok.  Some comment on
> the old code you refactored.

Should I fix this and repost?  Reviewed-by: plus suggestions is kind of
confusing. 8-)

Thanks,
Florian