From: Florian Weimer <fweimer@redhat.com>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: libc-alpha@gnu.org
Subject: Re: [PATCH v2 2/2] Split __path_search into a separate file
Date: Fri, 26 Aug 2022 11:47:00 +0200 [thread overview]
Message-ID: <878rnbtjzf.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20220825214634.3561419-3-eggert@cs.ucla.edu> (Paul Eggert's message of "Thu, 25 Aug 2022 14:46:34 -0700")
* Paul Eggert:
> This simplifies sharing tempname with Gnulib.
> Suggested by Bruno Haible in:
> https://lists.gnu.org/r/bug-gnulib/2022-08/msg00077.html
> * stdio-common/Makefile (routines): Add path-search.
> (CFLAGS-path-search.c): New macro, which has -fexceptions
> because tempname.c has it.
> * stdio-common/path-search.c, sysdeps/posix/path-search.c:
> New files.
> * stdio-common/tempname.c (__need_size_t): Do not define.
> No need to include stddef.h, since stdio.h declares size_t.
> (__path_search): Move to path-search.c.
> * sysdeps/posix/tempname.c:
> Don't include sys/types.h, assert.h, stddef.h; not needed.
> (P_tmpdir): Remove.
> (__secure_getenv) [_LIBC]: Remove.
> (__stat64) [!_LIBC]: Remove.
> (direxists, __path_search) [_LIBC]: Move to path-search.c.
sysdeps/posix/path-search.c is not intended to be shared with gnulib,
right? Change looks okay to me.
Thanks,
Florian
prev parent reply other threads:[~2022-08-26 9:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 21:46 [PATCH v2 0/2] tempname ALSR etc. fixes from Gnulib Paul Eggert
2022-08-25 21:46 ` Paul Eggert
2022-08-25 21:46 ` [PATCH v2 1/2] Merge tempname ASLR etc. patch " Paul Eggert
2022-08-25 21:46 ` Paul Eggert
2022-08-25 21:46 ` [PATCH v2 2/2] Split __path_search into a separate file Paul Eggert
2022-08-25 21:46 ` Paul Eggert
2022-08-26 9:47 ` Florian Weimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rnbtjzf.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=eggert@cs.ucla.edu \
--cc=libc-alpha@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).