From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 0970D3858D28 for ; Fri, 8 Apr 2022 22:27:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0970D3858D28 Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 238Ismxl005133 for ; Fri, 8 Apr 2022 22:27:35 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3fa4jxduu4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 08 Apr 2022 22:27:35 +0000 Received: from m0098421.ppops.net (m0098421.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 238MOkTN002987 for ; Fri, 8 Apr 2022 22:27:35 GMT Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0a-001b2d01.pphosted.com with ESMTP id 3fa4jxduty-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 08 Apr 2022 22:27:35 +0000 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 238M7l2M017516; Fri, 8 Apr 2022 22:27:34 GMT Received: from b01cxnp22034.gho.pok.ibm.com (b01cxnp22034.gho.pok.ibm.com [9.57.198.24]) by ppma01dal.us.ibm.com with ESMTP id 3f6e4awa3w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 08 Apr 2022 22:27:34 +0000 Received: from b01ledav004.gho.pok.ibm.com (b01ledav004.gho.pok.ibm.com [9.57.199.109]) by b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 238MRXTN57213376 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 8 Apr 2022 22:27:33 GMT Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 91070112063; Fri, 8 Apr 2022 22:27:33 +0000 (GMT) Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 41D45112061; Fri, 8 Apr 2022 22:27:33 +0000 (GMT) Received: from linux.ibm.com (unknown [9.65.88.206]) by b01ledav004.gho.pok.ibm.com (Postfix) with ESMTP; Fri, 8 Apr 2022 22:27:33 +0000 (GMT) From: Tulio Magno Quites Machado Filho To: libc-alpha@sourceware.org Cc: Alan Modra Subject: Re: [PATCH v2 0/4] PowerPC64 static-pie In-Reply-To: <20220228064052.3413334-1-amodra@gmail.com> References: <20220228064052.3413334-1-amodra@gmail.com> User-Agent: Notmuch/0.35 (http://notmuchmail.org) Emacs/27.2 (x86_64-redhat-linux-gnu) Date: Fri, 08 Apr 2022 19:27:32 -0300 Message-ID: <878rsf2otn.fsf@linux.ibm.com> Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-GUID: bCYEblSmXJreGHYka2UDpwEQRYWgCHs- X-Proofpoint-ORIG-GUID: O6o3hey8nhDsPsmg6EvYZz9Jtq1SB-bL X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.425,FMLib:17.11.64.514 definitions=2022-04-08_08,2022-04-08_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 phishscore=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 spamscore=0 bulkscore=0 mlxscore=0 impostorscore=0 adultscore=0 mlxlogscore=999 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2204080113 X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Apr 2022 22:27:37 -0000 Alan Modra via Libc-alpha writes: > This is a repost of the series at > https://sourceware.org/pipermail/libc-alpha/2022-January/135598.html > incorporating review comments. > > Changes are: > - subject lines changed to comply with glibc commit log standards > - patch 1/4 log now mentions making a couple of symbols hidden > - patch 2/4 makes at_platform available to early ifunc resolvers > as well as hwcap. > - patch 3/4 log mentions stinfo->init and stinfo->fini being unused > - patch 4/4 PI_STATIC_AND_HIDDEN comment explains what is going on > > patch 2/4 is the only code change from the previous series. Testsuite > results now show no regressions on powerpc64le-linux. I'm still seeing the following failures on powerpc64le-linux: FAIL: elf/tst-tls1-static-non-pie FAIL: gmon/tst-gmon-static FAIL: gmon/tst-gmon-static-gprof Am I missing anything? I used different GCC and Binutils versions ranging between: - GCC v8 and v11 - Binutils 2.30 and 2.38 (2020-03-04) Anyway, this is a summary of what I think about these patches: - Patch 1: Looks good to me. - Patch 2: Looks good to me. - Patch 3: Looks good to me after a minor change. - Patch 4: Hopefully I'm just missing a detail. Otherwise, I believe we should delay it until the previous issues are fixed. Let me elaborate this replying to each patch. -- Tulio Magno