From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fweimer@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by sourceware.org (Postfix) with ESMTP id 90E08386191C
 for <libc-alpha@sourceware.org>; Mon,  2 Aug 2021 16:25:51 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 90E08386191C
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-168-_QMU2_3hNjqZUziXrlkufg-1; Mon, 02 Aug 2021 12:25:48 -0400
X-MC-Unique: _QMU2_3hNjqZUziXrlkufg-1
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com
 [10.5.11.23])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2DF19801AEB;
 Mon,  2 Aug 2021 16:25:47 +0000 (UTC)
Received: from oldenburg.str.redhat.com (unknown [10.39.192.123])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 5501A19C59;
 Mon,  2 Aug 2021 16:25:46 +0000 (UTC)
From: Florian Weimer <fweimer@redhat.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: <libc-alpha@sourceware.org>
Subject: Re: Fix build of nptl/tst-thread_local1.cc with GCC 12
References: <alpine.DEB.2.22.394.2108021615400.701636@digraph.polyomino.org.uk>
Date: Mon, 02 Aug 2021 18:25:44 +0200
In-Reply-To: <alpine.DEB.2.22.394.2108021615400.701636@digraph.polyomino.org.uk>
 (Joseph Myers's message of "Mon, 2 Aug 2021 16:16:10 +0000")
Message-ID: <878s1jlson.fsf@oldenburg.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain
X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0,
 KAM_NUMSUBJECT, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,
 SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Aug 2021 16:25:52 -0000

* Joseph Myers:

> The test nptl/tst-thread_local1.cc fails to build with GCC mainline
> because of changes to what libstdc++ headers implicitly include what
> other headers:
>
> tst-thread_local1.cc: In function 'int do_test()':
> tst-thread_local1.cc:177:5: error: variable 'std::array<std::pair<const char*, std::function<void(void* (*)(void*))> >, 2> do_thread_X' has initializer but incomplete type
>   177 |     do_thread_X
>       |     ^~~~~~~~~~~
>
> Fix this by adding an explicit include of <array>.
>
> Tested with build-many-glibcs.py for aarch64-linux-gnu.
>
> diff --git a/nptl/tst-thread_local1.cc b/nptl/tst-thread_local1.cc
> index 9608afa..338aafe 100644
> --- a/nptl/tst-thread_local1.cc
> +++ b/nptl/tst-thread_local1.cc
> @@ -21,6 +21,7 @@
>  #include <stdio.h>
>  #include <string.h>
>  
> +#include <array>
>  #include <functional>
>  #include <string>
>  #include <thread>

Okay, thanks.

Florian