From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 44E87385BF84 for ; Sat, 10 Jul 2021 18:54:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 44E87385BF84 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-535-WTurK80GNNms3GLADMvFtw-1; Sat, 10 Jul 2021 14:54:21 -0400 X-MC-Unique: WTurK80GNNms3GLADMvFtw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 55510624; Sat, 10 Jul 2021 18:54:20 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-103.rdu2.redhat.com [10.10.112.103]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 718B3100164A; Sat, 10 Jul 2021 18:54:19 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH] Linux: Use 32-bit vDSO for clock_gettime, gettimeofday, time (bug 28071) References: <87czrqf5un.fsf@oldenburg.str.redhat.com> Date: Sat, 10 Jul 2021 20:54:10 +0200 In-Reply-To: (Adhemerval Zanella's message of "Sat, 10 Jul 2021 15:22:20 -0300") Message-ID: <878s2ef19p.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Jul 2021 18:54:24 -0000 * Adhemerval Zanella: > This does not fix the issue for __ASSUME_TIME64_SYSCALLS where it still uses > INLINE_SYSCALL_CALL which might clobber the errno, besides adding another > ifdef code path (which I really want to avoid). Instead I think we need to > open-coded the INLINE_VSYSCALL macro and replace all INLINE_SYSCALL_CALL > with INTERNAL_SYSCALL_CALLS: But for __ASSUME_TIME64_SYSCALLS, clock_gettime64 will not fail. What am I missing? Is the issue that INLINE_VSYSCALL may set ENOSYS artificially? Thanks, Florian