From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 123FF3857C74 for ; Fri, 7 May 2021 10:21:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 123FF3857C74 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-453-8idfFb5oMS-KnF9LBDy6Ng-1; Fri, 07 May 2021 06:20:57 -0400 X-MC-Unique: 8idfFb5oMS-KnF9LBDy6Ng-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DA6DF800D62; Fri, 7 May 2021 10:20:56 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-137.ams2.redhat.com [10.36.112.137]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1058F5C3FD; Fri, 7 May 2021 10:20:55 +0000 (UTC) From: Florian Weimer To: "H.J. Lu via Libc-alpha" Subject: Re: [PATCH v2] Run $(objpfx)iconvconfig with $(run-program-prefix) [BZ #27477] References: <20210226211507.3430032-1-hjl.tools@gmail.com> <871rajhon4.fsf@oldenburg.str.redhat.com> Date: Fri, 07 May 2021 12:21:15 +0200 In-Reply-To: (H. J. Lu via Libc-alpha's message of "Thu, 6 May 2021 11:04:14 -0700") Message-ID: <878s4qetes.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 May 2021 10:21:01 -0000 * H. J. Lu via Libc-alpha: >> Should tests use $(test-wrapper-env) instead of $(run-program-env) > > I think we should use > > $(run-program-prefix) $(objpfx)iconvconfig You are more familiar with the makefiles than I am. I do not have any objection to the proposed patch. Thanks, Florian