From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 07B683894416 for ; Fri, 7 May 2021 20:04:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 07B683894416 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 147K3X5A050018 for ; Fri, 7 May 2021 16:04:23 -0400 Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com [169.53.41.122]) by mx0a-001b2d01.pphosted.com with ESMTP id 38da76kmj9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 07 May 2021 16:04:22 -0400 Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1]) by ppma04dal.us.ibm.com (8.16.0.43/8.16.0.43) with SMTP id 147K3wTI032270 for ; Fri, 7 May 2021 20:04:22 GMT Received: from b03cxnp07029.gho.boulder.ibm.com (b03cxnp07029.gho.boulder.ibm.com [9.17.130.16]) by ppma04dal.us.ibm.com with ESMTP id 38csqgytwm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 07 May 2021 20:04:22 +0000 Received: from b03ledav005.gho.boulder.ibm.com (b03ledav005.gho.boulder.ibm.com [9.17.130.236]) by b03cxnp07029.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 147K4KYQ23003492 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 7 May 2021 20:04:20 GMT Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 92D8ABE056; Fri, 7 May 2021 20:04:20 +0000 (GMT) Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DB47FBE04F; Fri, 7 May 2021 20:04:19 +0000 (GMT) Received: from linux.ibm.com (unknown [9.145.84.153]) by b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTP; Fri, 7 May 2021 20:04:19 +0000 (GMT) From: Tulio Magno Quites Machado Filho To: Raoni Fassina Firmino , libc-alpha@sourceware.org Subject: Re: [PATCH] powerpc64le: Fix ifunc selection for memset, memmove, bzero and bcopy In-Reply-To: <20210503195935.je5jbi6hjbiiaovs@work-tp> References: <20210503195935.je5jbi6hjbiiaovs@work-tp> User-Agent: Notmuch/0.31.3 (http://notmuchmail.org) Emacs/27.2 (x86_64-redhat-linux-gnu) Date: Fri, 07 May 2021 17:04:17 -0300 Message-ID: <878s4qxqda.fsf@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-GUID: Cmt_rd7F5YxmHSVkIBN01-jXDccYm70E X-Proofpoint-ORIG-GUID: Cmt_rd7F5YxmHSVkIBN01-jXDccYm70E X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-05-07_08:2021-05-06, 2021-05-07 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 impostorscore=0 malwarescore=0 mlxlogscore=630 bulkscore=0 clxscore=1015 mlxscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2105070131 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 May 2021 20:04:25 -0000 Raoni Fassina Firmino via Libc-alpha writes: > The hwcap2 check for the aforementioned functions should check for > both PPC_FEATURE2_ARCH_3_1 and PPC_FEATURE2_HAS_ISEL but was > mistakenly checking for any one of them, enabling isa 3.1 version of > the functions in incompatible processors, like POWER8. LGTM. This time, tested on POWER8 too. Pushed as 17a73a6d8b4c46f3e87fc53c7c25fa7cec01d707. Thank you! -- Tulio Magno