From: Andreas Schwab <schwab@linux-m68k.org>
To: Lirong Yuan <yuanzi@google.com>
Cc: Lirong Yuan via Libc-alpha <libc-alpha@sourceware.org>,
Shu-Chun Weng <scw@google.com>
Subject: Re: [PATCH v2] locale: update _nl_C_LC_CTYPE_class and _nl_C_LC_CTYPE_class32 arrays to have types uint16_t and uint32_t respectively
Date: Tue, 30 Mar 2021 20:33:51 +0200 [thread overview]
Message-ID: <878s644hkg.fsf@igel.home> (raw)
In-Reply-To: <CADjx4C+Skv4mBk3mLNbC6o3JZ054huj4wcTzYWuvxTLYsaohSw@mail.gmail.com> (Lirong Yuan's message of "Tue, 30 Mar 2021 11:04:13 -0700")
On Mär 30 2021, Lirong Yuan wrote:
> Since the `_nl_C_LC_CTYPE_class` array is accessed by unsigned short
> pointers, I assumed that endianness does not matter.
Of course it does, you changed an endian-independent representation to
an edian-dependent one.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2021-03-30 18:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 17:25 Lirong Yuan
2021-03-30 17:57 ` Andreas Schwab
2021-03-30 18:04 ` Lirong Yuan
2021-03-30 18:33 ` Andreas Schwab [this message]
2021-03-30 19:03 ` Lirong Yuan
2021-04-01 8:22 ` Andreas Schwab
2021-04-01 17:29 ` Lirong Yuan
2021-04-01 18:55 ` Adhemerval Zanella
2021-04-01 19:42 ` Lirong Yuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878s644hkg.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=libc-alpha@sourceware.org \
--cc=scw@google.com \
--cc=yuanzi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).