public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fw@deneb.enyo.de>
To: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH v2 03/14] nptl: Remove lseek from libpthread
Date: Thu, 25 Mar 2021 14:37:26 +0100	[thread overview]
Message-ID: <878s6bnyll.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <20210319202914.2475530-4-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Fri, 19 Mar 2021 17:29:03 -0300")

* Adhemerval Zanella via Libc-alpha:

> The libc version is identical and built with same flags.  The libc
> version is set as the default version.
>
> The libpthread compat symbol requires to mask it when building the
> loader object otherwise ld might complain about a missing
> versioned symbol (as for alpha).
>
> Checked on x86_64-linux-gnu.
> ---
>  include/unistd.h                                           | 3 +--
>  nptl/Makefile                                              | 1 -
>  nptl/Versions                                              | 3 ---
>  sysdeps/unix/sysv/linux/aarch64/libpthread.abilist         | 3 ---
>  sysdeps/unix/sysv/linux/alpha/libc.abilist                 | 1 +
>  sysdeps/unix/sysv/linux/alpha/libpthread.abilist           | 3 ---
>  sysdeps/unix/sysv/linux/arc/libpthread.abilist             | 3 ---
>  sysdeps/unix/sysv/linux/arm/be/libpthread.abilist          | 3 ---
>  sysdeps/unix/sysv/linux/arm/le/libpthread.abilist          | 3 ---
>  sysdeps/unix/sysv/linux/csky/libpthread.abilist            | 3 ---
>  sysdeps/unix/sysv/linux/hppa/libpthread.abilist            | 3 ---
>  sysdeps/unix/sysv/linux/i386/libc.abilist                  | 1 +
>  sysdeps/unix/sysv/linux/i386/libpthread.abilist            | 3 ---
>  sysdeps/unix/sysv/linux/ia64/libpthread.abilist            | 3 ---
>  sysdeps/unix/sysv/linux/lseek64.c                          | 7 +++++--
>  sysdeps/unix/sysv/linux/m68k/coldfire/libpthread.abilist   | 3 ---
>  sysdeps/unix/sysv/linux/m68k/m680x0/libc.abilist           | 1 +
>  sysdeps/unix/sysv/linux/m68k/m680x0/libpthread.abilist     | 3 ---
>  sysdeps/unix/sysv/linux/microblaze/be/libpthread.abilist   | 3 ---
>  sysdeps/unix/sysv/linux/microblaze/le/libpthread.abilist   | 3 ---
>  sysdeps/unix/sysv/linux/mips/mips32/libpthread.abilist     | 3 ---
>  sysdeps/unix/sysv/linux/mips/mips64/libpthread.abilist     | 3 ---
>  sysdeps/unix/sysv/linux/nios2/libpthread.abilist           | 3 ---
>  sysdeps/unix/sysv/linux/powerpc/powerpc32/fpu/libc.abilist | 1 +
>  .../unix/sysv/linux/powerpc/powerpc32/libpthread.abilist   | 3 ---
>  .../unix/sysv/linux/powerpc/powerpc32/nofpu/libc.abilist   | 1 +
>  .../sysv/linux/powerpc/powerpc64/be/libpthread.abilist     | 3 ---
>  .../sysv/linux/powerpc/powerpc64/le/libpthread.abilist     | 3 ---
>  sysdeps/unix/sysv/linux/riscv/rv32/libpthread.abilist      | 3 ---
>  sysdeps/unix/sysv/linux/riscv/rv64/libpthread.abilist      | 3 ---
>  sysdeps/unix/sysv/linux/s390/s390-32/libc.abilist          | 1 +
>  sysdeps/unix/sysv/linux/s390/s390-32/libpthread.abilist    | 3 ---
>  sysdeps/unix/sysv/linux/s390/s390-64/libpthread.abilist    | 3 ---
>  sysdeps/unix/sysv/linux/sh/be/libpthread.abilist           | 3 ---
>  sysdeps/unix/sysv/linux/sh/le/libpthread.abilist           | 3 ---
>  sysdeps/unix/sysv/linux/sparc/sparc32/libc.abilist         | 1 +
>  sysdeps/unix/sysv/linux/sparc/sparc32/libpthread.abilist   | 3 ---
>  sysdeps/unix/sysv/linux/sparc/sparc64/libpthread.abilist   | 3 ---
>  sysdeps/unix/sysv/linux/x86_64/64/libpthread.abilist       | 3 ---
>  sysdeps/unix/sysv/linux/x86_64/x32/libpthread.abilist      | 3 ---
>  40 files changed, 13 insertions(+), 95 deletions(-)

As far as I can tell, this patch is okay.

  reply	other threads:[~2021-03-25 13:37 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-19 20:29 [PATCH v2 00/14] libpthread removal: pthread-compat-wrappers and other libc symbols Adhemerval Zanella
2021-03-19 20:29 ` [PATCH v2 01/14] Add OTHER_SHLIB_COMPAT Adhemerval Zanella
2021-03-19 20:36   ` Florian Weimer
2021-03-19 20:29 ` [PATCH v2 02/14] nptl: Remove send from libpthread Adhemerval Zanella
2021-03-25 13:36   ` Florian Weimer
2021-03-19 20:29 ` [PATCH v2 03/14] nptl: Remove lseek " Adhemerval Zanella
2021-03-25 13:37   ` Florian Weimer [this message]
2021-03-19 20:29 ` [PATCH v2 04/14] nptl: Remove open " Adhemerval Zanella
2021-03-25 13:46   ` Florian Weimer
2021-03-19 20:29 ` [PATCH v2 05/14] nptl: Remove pread " Adhemerval Zanella
2021-03-25 14:07   ` Florian Weimer
2021-03-19 20:29 ` [PATCH v2 06/14] nptl: Remove pwrite " Adhemerval Zanella
2021-03-25 14:11   ` Florian Weimer
2021-03-19 20:29 ` [PATCH v2 07/14] nptl: Remove msgsnd from pthread-compat-wrappers Adhemerval Zanella
2021-03-25 14:33   ` Florian Weimer
2021-03-19 20:29 ` [PATCH v2 08/14] nptl: Remove msgrcv " Adhemerval Zanella
2021-03-25 14:33   ` Florian Weimer
2021-03-19 20:29 ` [PATCH v2 09/14] nptl: Remove sigsuspend " Adhemerval Zanella
2021-03-25 14:34   ` Florian Weimer
2021-03-19 20:29 ` [PATCH v2 10/14] nptl: Move pthread_kill to libc Adhemerval Zanella
2021-03-25 14:45   ` Florian Weimer
2021-03-19 20:29 ` [PATCH v2 11/14] nptl: Remove pthread raise implementation Adhemerval Zanella
2021-03-25 14:49   ` Florian Weimer
2021-03-19 20:29 ` [PATCH v2 12/14] nptl: Move sigaction to libc Adhemerval Zanella
2021-03-25 15:00   ` Florian Weimer
2021-03-19 20:29 ` [PATCH v2 13/14] nptl: Remove __libc_allocate_rtsig, __libc_current_sigrtmax, and __libc_current_sigrtmin Adhemerval Zanella
2021-03-25 15:31   ` Florian Weimer
2021-03-19 20:29 ` [PATCH v2 14/14] nptl: Remove unused rules Adhemerval Zanella
2021-03-25 15:33   ` Florian Weimer
2021-03-25 17:59 ` [PATCH v2 00/14] libpthread removal: pthread-compat-wrappers and other libc symbols Florian Weimer
2021-03-25 18:13   ` Adhemerval Zanella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878s6bnyll.fsf@mid.deneb.enyo.de \
    --to=fw@deneb.enyo.de \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).