From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id C9C643857C5F for ; Wed, 24 Mar 2021 15:08:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C9C643857C5F Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-518-F12-wou4PRWejNpom8G0mw-1; Wed, 24 Mar 2021 11:08:07 -0400 X-MC-Unique: F12-wou4PRWejNpom8G0mw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 40374881283; Wed, 24 Mar 2021 15:08:06 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-80.ams2.redhat.com [10.36.112.80]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 505A46A97F; Wed, 24 Mar 2021 15:08:05 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH v3 24/37] nptl: Move pthread_key_create, __pthread_key_create into libc References: <5118e919-fac6-a116-5f39-3915fdc0e0af@linaro.org> <87h7l0wrjj.fsf@oldenburg.str.redhat.com> <0794e296-158f-26a4-f49b-b8e8aef5b305@linaro.org> Date: Wed, 24 Mar 2021 16:08:25 +0100 In-Reply-To: <0794e296-158f-26a4-f49b-b8e8aef5b305@linaro.org> (Adhemerval Zanella's message of "Wed, 24 Mar 2021 11:42:05 -0300") Message-ID: <878s6cwpw6.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Mar 2021 15:08:14 -0000 * Adhemerval Zanella: > Sigh... the description at libgcc/gthr-posix.h is *really* hacky and I > think we provide the __libc_single_threaded exactly to avoid keep > providing this kind of interfaces. The newer versions should use it, but there is just one header file shared by everything POSIX-like. >> Right that, applies in other places throughout the series, too. >> >> Speaking of which, should I repost the compat_symbol patches? > > Isn't the one in patchwork the latest [1]? > > [1] https://patchwork.sourceware.org/project/glibc/patch/07c2defd7f03c5f2493a4132de673f33457d7806.1616184336.git.fweimer@redhat.com/ I think it lacks the __attribute__ ((nocommon)) for __malloc_initialize_hook (need for building with GCC 9 and earlier). Thanks, Florian