Re: [PATCH v2 2/2] x86: Add CPU-specific diagnostics to ld.so --list-diagnostics

[Florian Weimer <fweimer@redhat.com>]

* H. J. Lu via Libc-alpha:

>> +  print_cpu_feature_preferred
>> +    ("prefer_no_avx512",
>> +     CPU_FEATURE_PREFERRED_P (cpu_features, Prefer_No_AVX512));
>> +  print_cpu_feature_preferred
>> +    ("mathvec_prefer_no_avx512",
>> +     CPU_FEATURE_PREFERRED_P (cpu_features, MathVec_Prefer_No_AVX512));
>
> $ grep "#define index_arch_" sysdeps/x86/include/cpu-features.h | awk
> '{ print $2 }' | sed -e "s/index_arch_//"
> Fast_Rep_String
> Fast_Copy_Backward
> Slow_BSF
> Fast_Unaligned_Load
> Prefer_PMINUB_for_stringop
> Fast_Unaligned_Copy
> I586
> I686
> Slow_SSE4_2
> AVX_Fast_Unaligned_Load
> Prefer_MAP_32BIT_EXEC
> Prefer_No_VZEROUPPER
> Prefer_ERMS
> Prefer_No_AVX512
> MathVec_Prefer_No_AVX512
> Prefer_FSRM
>
> sysdeps/x86/configure.ac can generate the list.

Okay, I will automate this in some way.

>> +  print_cpu_features_value ("level3_cache_linesize",
>> +                            cpu_features->level3_cache_linesize);
>> +  print_cpu_features_value ("level4_cache_size",
>> +                            cpu_features->level4_cache_size);
>
> Please assert size of *cpu_features == offfset of level4_cache_size
> + sizeof (level4_cache_size).

I'm going to add a static assert.

Thanks,
Florian