public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Carlos O'Donell <carlos@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: NSS chroot protection
Date: Fri, 19 Feb 2021 11:11:37 +0100	[thread overview]
Message-ID: <878s7kfjty.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <6bb1d215-58e2-c4a6-e81c-8f2592a8fcb3@redhat.com> (Carlos O'Donell's message of "Tue, 16 Feb 2021 17:22:16 -0500")

* Carlos O'Donell:

>> Should we revert the second part and keep loading new service modules?
>
> I dislike reverting the fix. It is natural to create a boundary between
> the configuration outside of the chroot and inside of the chroot.
>
> May I suggest a more radical approach?
>
> Load all the NSS service modules when the first modules is loaded,
> and keep the the fix in place?

It will likely break systems like dpkg and RPM, where NSS library
dependencies can be temporarily inconsistent during updates.  As long as
those NSS modules fail to load, nothing bad will happen, but if there
are crashes due to ABI mismatches exposed by ELF constructors, we have
introduced upgrade failures.  (Such failures can be very difficult to
recover from on RPM systems.)  This wouldn't be something that I'd feel
comfortable backporting.  Lazy loading tends to paper over these
problems because updates typically only need files data for system
accounts.

Loading an NSS module which depends on libpthread may also not be safe
for all processes.  With the current lazy loading scheme, we avoid some
bugs related to late loading of libpthread because many processes only
need dns or files, which do not depend on libpthread.

Thanks,
Florian


      parent reply	other threads:[~2021-02-19 10:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-16 12:11 Florian Weimer
2021-02-16 22:22 ` Carlos O'Donell
2021-02-17  7:36   ` Stefan Liebler
2021-02-19 10:11   ` Florian Weimer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878s7kfjty.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=carlos@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).