From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 1353F3858020 for ; Mon, 19 Oct 2020 08:19:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1353F3858020 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-584-hOCcSV0wOZupHxCkvhnFQw-1; Mon, 19 Oct 2020 04:19:02 -0400 X-MC-Unique: hOCcSV0wOZupHxCkvhnFQw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6A477100A244; Mon, 19 Oct 2020 08:19:01 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-112-203.ams2.redhat.com [10.36.112.203]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4CCFD5B4A0; Mon, 19 Oct 2020 08:18:59 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: Adhemerval Zanella via Libc-alpha , James Clarke , John Paul Adrian Glaubitz Subject: Re: [PATCH v2 4/9] linux: Use getdents64 on non-LFS readdir References: <20201002170620.1611673-1-adhemerval.zanella@linaro.org> <20201002170620.1611673-5-adhemerval.zanella@linaro.org> <87d01mrub9.fsf@oldenburg2.str.redhat.com> <944cda4b-0681-0000-162d-80cc2b805111@linaro.org> Date: Mon, 19 Oct 2020 10:18:58 +0200 In-Reply-To: <944cda4b-0681-0000-162d-80cc2b805111@linaro.org> (Adhemerval Zanella's message of "Thu, 15 Oct 2020 11:25:26 -0300") Message-ID: <878sc2d3wt.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Oct 2020 08:19:06 -0000 * Adhemerval Zanella: > Using a single allocation make the code slight faster (which not sure if > plays much difference since a lot of memory copy would be required for > non-LFS) and it does not require to handle the possible reallocation > failure on readdir. But you'd still have to handle the case where name is longer than the allocation, to avoid a buffer overflow. So an error case still exists. Thanks, Florian -- Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243, Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill