public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
Subject: Re: V3 [PATCH] nptl: Zero-extend arguments to SETXID syscalls [BZ #26248]
Date: Mon, 27 Jul 2020 17:49:23 +0200	[thread overview]
Message-ID: <878sf5ufek.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <CAMe9rOrymSgUHAER35zJj9T47=hdtE2A0N-FnzyMZucvcaz48A@mail.gmail.com> (H. J. Lu via Libc-alpha's message of "Mon, 27 Jul 2020 07:29:53 -0700")

* H. J. Lu via Libc-alpha:

> +  /* Enforce zero-extension for the pointer argument in
> +
> +     int setgroups(size_t size, const gid_t *list);
> +
> +     The kernel XID arguments are unsigned and do not require sign
> +     extension.  */
> +  unsigned long int id[3];

Maybe add the missing space before '('?

Rest looks good to me for glibc 2.32.

Thanks,
Florian


  reply	other threads:[~2020-07-27 15:49 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-16 11:26 [PATCH] nptl: Properly inline setgroups syscall " H.J. Lu
2020-07-16 12:03 ` Florian Weimer
2020-07-16 12:46   ` [PATCH] nptl: Zero-extend arguments to SETXID syscalls " H.J. Lu
2020-07-16 15:57     ` Florian Weimer
2020-07-16 16:00       ` H.J. Lu
2020-07-16 19:38       ` Aurelien Jarno
2020-07-16 19:45     ` Aurelien Jarno
2020-07-16 21:42       ` H.J. Lu
2020-07-17  2:14         ` Carlos O'Donell
2020-07-17  2:46           ` H.J. Lu
2020-07-17 15:01     ` Carlos O'Donell
2020-07-17 15:13       ` Florian Weimer
2020-07-17 15:52         ` Carlos O'Donell
2020-07-17 19:31           ` H.J. Lu
2020-07-17 21:22             ` Carlos O'Donell
2020-07-23 20:03               ` H.J. Lu
2020-07-23 21:11                 ` Carlos O'Donell
2020-07-23 21:17                   ` Adhemerval Zanella
2020-07-23 21:20                     ` Carlos O'Donell
2020-07-27  3:37                   ` Carlos O'Donell
2020-07-27  6:00                     ` Florian Weimer
2020-07-27 11:55                       ` H.J. Lu
2020-07-27 12:20                         ` Florian Weimer
2020-07-27 14:29                           ` V3 " H.J. Lu
2020-07-27 15:49                             ` Florian Weimer [this message]
2020-07-27 19:17                               ` H.J. Lu
2020-07-20 11:38           ` Florian Weimer
2020-07-17 19:42       ` V2 " H.J. Lu
2020-07-17 22:27         ` Aurelien Jarno
2020-07-17 22:31           ` H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878sf5ufek.fsf@oldenburg2.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).