From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) by sourceware.org (Postfix) with ESMTPS id 0609F3898518 for ; Thu, 30 Apr 2020 14:04:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0609F3898518 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=whitebox@nefkom.net Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 49CcZv6f8hz1qs0Y; Thu, 30 Apr 2020 16:04:55 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 49CcZv6Lwpz1qspQ; Thu, 30 Apr 2020 16:04:55 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id HwI5zWB2VRbh; Thu, 30 Apr 2020 16:04:55 +0200 (CEST) X-Auth-Info: tuAw7pRt/xLazVIzwGB0MSxUriZ5lvVGK3ItcLp4EihvR6C/tQad2jQHbdTXxP44 Received: from igel.home (ppp-46-244-166-8.dynamic.mnet-online.de [46.244.166.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Thu, 30 Apr 2020 16:04:55 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id 8FAA92C0FA1; Thu, 30 Apr 2020 16:04:54 +0200 (CEST) From: Andreas Schwab To: "H.J. Lu" Cc: Florian Weimer , "H.J. Lu via Libc-alpha" Subject: Re: V2 [PATCH] Add a C wrapper for prctl [BZ #25896] References: <20200429205217.2435607-1-hjl.tools@gmail.com> <87wo5xa0yt.fsf@mid.deneb.enyo.de> <20200430130333.GA254612@gmail.com> <87h7x1gkfg.fsf@igel.home> <87mu6t84yg.fsf@mid.deneb.enyo.de> <87d07pgjz0.fsf@igel.home> X-Yow: I'm protected by a ROLL-ON I rented from AVIS.. Date: Thu, 30 Apr 2020 16:04:54 +0200 In-Reply-To: (H. J. Lu's message of "Thu, 30 Apr 2020 06:53:51 -0700") Message-ID: <878sidgjcp.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-17.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Apr 2020 14:05:07 -0000 On Apr 30 2020, H.J. Lu wrote: > On Thu, Apr 30, 2020 at 6:51 AM Andreas Schwab wrote: >> >> On Apr 30 2020, Florian Weimer wrote: >> >> > * Andreas Schwab: >> > >> >> On Apr 30 2020, H.J. Lu via Libc-alpha wrote: >> >> >> >>> diff --git a/include/sys/prctl.h b/include/sys/prctl.h >> >>> index 0920ed642b..1a74d83879 100644 >> >>> --- a/include/sys/prctl.h >> >>> +++ b/include/sys/prctl.h >> >>> @@ -4,6 +4,8 @@ >> >>> # ifndef _ISOMAC >> >>> >> >>> extern int __prctl (int __option, ...); >> >>> +libc_hidden_proto (__prctl) >> >>> +libc_hidden_proto (prctl) >> >> >> >> Why do you need the hidden alias for prctl? All references inside >> >> libc.so should use __prctl. >> > >> > Right. I want to clean this up in a separate patch. >> >> ??? Why adding it in the first place? >> >> Andreas. >> > > It was there before my patch: That doesn't matter, the syscall template adds it blindly to all names. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."