* Test suite failures with GCC 11 in header checks
@ 2023-07-20 8:01 Florian Weimer
2023-07-20 9:26 ` Florian Weimer
0 siblings, 1 reply; 6+ messages in thread
From: Florian Weimer @ 2023-07-20 8:01 UTC (permalink / raw)
To: libc-alpha; +Cc: Frederic Berat, Siddhesh Poyarekar
The test suite currently runs header checks with -D_FORTIFY_SOURCE=3
even if the compiler does not support it (such as GCC 11), leading to
failures.
Has this already been discussed? Should be resolved before the release?
Thanks,
Florian
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Test suite failures with GCC 11 in header checks
2023-07-20 8:01 Test suite failures with GCC 11 in header checks Florian Weimer
@ 2023-07-20 9:26 ` Florian Weimer
2023-07-20 9:37 ` Frederic Berat
2023-07-20 13:25 ` MAHESH BODAPATI
0 siblings, 2 replies; 6+ messages in thread
From: Florian Weimer @ 2023-07-20 9:26 UTC (permalink / raw)
To: libc-alpha
Cc: Adhemerval Zanella, Carlos O'Donell, Frederic Berat,
Siddhesh Poyarekar
* Florian Weimer:
> The test suite currently runs header checks with -D_FORTIFY_SOURCE=3
> even if the compiler does not support it (such as GCC 11), leading to
> failures.
>
> Has this already been discussed? Should be resolved before the release?
It's a regression introduced yesterday:
commit 30379efad117b85cc56a255cac628d0ad745bfe3
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date: Wed Jul 19 11:37:01 2023 -0300
scripts: Add fortify checks on installed headers
The _FORTIFY_SOURCE is used as default by some system compilers,
and there is no way to check if some fortify extension does not
trigger any conformance issue.
Checked on x86_64-linux-gnu.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Thanks,
Florian
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Test suite failures with GCC 11 in header checks
2023-07-20 9:26 ` Florian Weimer
@ 2023-07-20 9:37 ` Frederic Berat
2023-07-20 11:05 ` Adhemerval Zanella Netto
2023-07-20 13:25 ` MAHESH BODAPATI
1 sibling, 1 reply; 6+ messages in thread
From: Frederic Berat @ 2023-07-20 9:37 UTC (permalink / raw)
To: Florian Weimer
Cc: libc-alpha, Adhemerval Zanella, Carlos O'Donell, Siddhesh Poyarekar
[-- Attachment #1: Type: text/plain, Size: 1457 bytes --]
On Thu, Jul 20, 2023 at 11:26 AM Florian Weimer <fweimer@redhat.com> wrote:
> * Florian Weimer:
>
> > The test suite currently runs header checks with -D_FORTIFY_SOURCE=3
> > even if the compiler does not support it (such as GCC 11), leading to
> > failures.
> >
> > Has this already been discussed? Should be resolved before the release?
>
> It's a regression introduced yesterday:
>
> commit 30379efad117b85cc56a255cac628d0ad745bfe3
> Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> Date: Wed Jul 19 11:37:01 2023 -0300
>
> scripts: Add fortify checks on installed headers
>
> The _FORTIFY_SOURCE is used as default by some system compilers,
> and there is no way to check if some fortify extension does not
> trigger any conformance issue.
>
> Checked on x86_64-linux-gnu.
>
> Reviewed-by: Carlos O'Donell <carlos@redhat.com>
>
>
Some suggestions for the fix, instead of reverting that:
One can probably make use of the variables created by configure to define
the maximum level to be tested.
There is "enable_fortify_source" that should hold the level used to
configure glibc, assuming configure is run using GCC11, then this variable
will be set to 2.
As of now, this variable isn't used outside of the configure script, but it
could be (either by substituting the values in the script or by passing it
as an argument through the makefile).
> Thanks,
> Florian
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Test suite failures with GCC 11 in header checks
2023-07-20 9:37 ` Frederic Berat
@ 2023-07-20 11:05 ` Adhemerval Zanella Netto
2023-07-20 11:09 ` Siddhesh Poyarekar
0 siblings, 1 reply; 6+ messages in thread
From: Adhemerval Zanella Netto @ 2023-07-20 11:05 UTC (permalink / raw)
To: Frederic Berat, Florian Weimer
Cc: libc-alpha, Carlos O'Donell, Siddhesh Poyarekar
On 20/07/23 06:37, Frederic Berat wrote:
>
>
> On Thu, Jul 20, 2023 at 11:26 AM Florian Weimer <fweimer@redhat.com <mailto:fweimer@redhat.com>> wrote:
>
> * Florian Weimer:
>
> > The test suite currently runs header checks with -D_FORTIFY_SOURCE=3
> > even if the compiler does not support it (such as GCC 11), leading to
> > failures.
> >
> > Has this already been discussed? Should be resolved before the release?
>
> It's a regression introduced yesterday:
>
> commit 30379efad117b85cc56a255cac628d0ad745bfe3
> Author: Adhemerval Zanella <adhemerval.zanella@linaro.org <mailto:adhemerval.zanella@linaro.org>>
> Date: Wed Jul 19 11:37:01 2023 -0300
>
> scripts: Add fortify checks on installed headers
>
> The _FORTIFY_SOURCE is used as default by some system compilers,
> and there is no way to check if some fortify extension does not
> trigger any conformance issue.
>
> Checked on x86_64-linux-gnu.
>
> Reviewed-by: Carlos O'Donell <carlos@redhat.com <mailto:carlos@redhat.com>>
>
>
> Some suggestions for the fix, instead of reverting that:
> One can probably make use of the variables created by configure to define the maximum level to be tested.
> There is "enable_fortify_source" that should hold the level used to configure glibc, assuming configure is run using GCC11, then this variable will be set to 2.
> As of now, this variable isn't used outside of the configure script, but it could be (either by substituting the values in the script or by passing it as an argument through the makefile).
I will check this today, another option would to just use maximum level of '2'
for now.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Test suite failures with GCC 11 in header checks
2023-07-20 11:05 ` Adhemerval Zanella Netto
@ 2023-07-20 11:09 ` Siddhesh Poyarekar
0 siblings, 0 replies; 6+ messages in thread
From: Siddhesh Poyarekar @ 2023-07-20 11:09 UTC (permalink / raw)
To: Adhemerval Zanella Netto, Frederic Berat, Florian Weimer
Cc: libc-alpha, Carlos O'Donell, Siddhesh Poyarekar
On 2023-07-20 07:05, Adhemerval Zanella Netto via Libc-alpha wrote:
> I will check this today, another option would to just use maximum level of '2'
> for now.
>
Yeah, that ought to be sufficient for installed header tests.
Thanks,
Sid
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Test suite failures with GCC 11 in header checks
2023-07-20 9:26 ` Florian Weimer
2023-07-20 9:37 ` Frederic Berat
@ 2023-07-20 13:25 ` MAHESH BODAPATI
1 sibling, 0 replies; 6+ messages in thread
From: MAHESH BODAPATI @ 2023-07-20 13:25 UTC (permalink / raw)
To: libc-alpha
[-- Attachment #1: Type: text/plain, Size: 1028 bytes --]
On 20/07/23 2:56 pm, Florian Weimer via Libc-alpha wrote:
> * Florian Weimer:
>
>> The test suite currently runs header checks with -D_FORTIFY_SOURCE=3
>> even if the compiler does not support it (such as GCC 11), leading to
>> failures.
>>
>> Has this already been discussed? Should be resolved before the release
We too noticed the test failures for PowerPC.
*error: #warning _FORTIFY_SOURCE > 2 is treated like 2 on this platform
[-Werror=cpp]*
> It's a regression introduced yesterday:
>
> commit 30379efad117b85cc56a255cac628d0ad745bfe3
> Author: Adhemerval Zanella<adhemerval.zanella@linaro.org>
> Date: Wed Jul 19 11:37:01 2023 -0300
>
> scripts: Add fortify checks on installed headers
>
> The _FORTIFY_SOURCE is used as default by some system compilers,
> and there is no way to check if some fortify extension does not
> trigger any conformance issue.
>
> Checked on x86_64-linux-gnu.
>
> Reviewed-by: Carlos O'Donell<carlos@redhat.com>
>
> Thanks,
> Florian
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-07-20 13:25 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-20 8:01 Test suite failures with GCC 11 in header checks Florian Weimer
2023-07-20 9:26 ` Florian Weimer
2023-07-20 9:37 ` Frederic Berat
2023-07-20 11:05 ` Adhemerval Zanella Netto
2023-07-20 11:09 ` Siddhesh Poyarekar
2023-07-20 13:25 ` MAHESH BODAPATI
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).