From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 9D4D03857C4C for ; Mon, 1 Aug 2022 15:49:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9D4D03857C4C Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-86-TCFA5TkhNDuy1UR6aDWEAQ-1; Mon, 01 Aug 2022 11:49:36 -0400 X-MC-Unique: TCFA5TkhNDuy1UR6aDWEAQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CA59C3826A4C; Mon, 1 Aug 2022 15:49:35 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F1F521121314; Mon, 1 Aug 2022 15:49:34 +0000 (UTC) From: Florian Weimer To: Andreas Schwab via Libc-alpha Cc: Andreas Schwab Subject: Re: [PATCH] Don't use unsupported format string in ld.so (bug 29427) References: Date: Mon, 01 Aug 2022 17:49:33 +0200 In-Reply-To: (Andreas Schwab via Libc-alpha's message of "Mon, 01 Aug 2022 16:46:13 +0200") Message-ID: <87a68om0aa.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Aug 2022 15:49:42 -0000 * Andreas Schwab via Libc-alpha: > There is no support for printf format strings that contain a literal field > width or precision in the dynamic loader, they have to be specified > indirectly. > --- > elf/dl-diagnostics.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/elf/dl-diagnostics.c b/elf/dl-diagnostics.c > index dd3871b1e0..269c428c93 100644 > --- a/elf/dl-diagnostics.c > +++ b/elf/dl-diagnostics.c > @@ -108,7 +108,7 @@ _dl_diagnostics_print_labeled_value (const char *label, uint64_t value) > if (high == 0) > _dl_printf ("%s=0x%x\n", label, low); > else > - _dl_printf ("%s=0x%x%08x\n", label, high, low); > + _dl_printf ("%s=0x%x%0*x\n", label, high, 8, low); > } > } > > -- > > 2.37.1 Looks okay to me. Reviewed-by: Florian Weimer Thanks, Florian